From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753713AbcCAMva (ORCPT <rfc822;w@1wt.eu>);
	Tue, 1 Mar 2016 07:51:30 -0500
Received: from mx1.redhat.com ([209.132.183.28]:47447 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753684AbcCAMv1 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 1 Mar 2016 07:51:27 -0500
Date: Tue, 1 Mar 2016 13:51:24 +0100
From: Jiri Olsa <jolsa@redhat.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>, Wang Nan <wangnan0@huawei.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: libbabeltrace feature detection message
Message-ID: <20160301125124.GA26168@krava.redhat.com>
References: <20160229150720.GC32719@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160229150720.GC32719@kernel.org>
User-Agent: Mutt/1.5.24 (2015-08-30)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Tue, 01 Mar 2016 12:51:27 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Feb 29, 2016 at 12:07:20PM -0300, Arnaldo Carvalho de Melo wrote:
> 
> Hi Jiri,
> 
> 	While testing a patch by Wang, that requires building with
> libbabeltrace, I noticed that there are no feature detection message
> telling that it was found successfully. The end result is the desired
> one, it builds with babeltrace, but I wonder if we couldn't have the
> [ok] line for it:

well, we removed it, because the latest version if libbabeltrace pkg
perf needs wasn't present in common distros.. so for most users that
would print 'OFF' as a status.. that might have changed now, dont know

anyway, for libbabeltrace and other in FEATURE_TESTS_EXTRA it's not possible
to print their status easily at the moment, because the status isn't known at
the time tools/build/Makefile.feature is included in config/Makefile

I'll check if we can reorg the code a little to get the full status at the end

jirka

> 
> 
> [acme@jouet linux]$ rm -rf /tmp/build/perf ; mkdir -p /tmp/build/perf ; make LIBBABELTRACE=1 O=/tmp/build/perf -C tools/perf install-bin
> make: Entering directory '/home/acme/git/linux/tools/perf'
>   BUILD:   Doing 'make -j4' parallel build
> 
> Auto-detecting system features:
> ...                         dwarf: [ on  ]
> ...                         glibc: [ on  ]
> ...                          gtk2: [ on  ]
> ...                      libaudit: [ on  ]
> ...                        libbfd: [ on  ]
> ...                        libelf: [ on  ]
> ...                       libnuma: [ on  ]
> ...        numa_num_possible_cpus: [ on  ]
> ...                       libperl: [ on  ]
> ...                     libpython: [ on  ]
> ...                      libslang: [ on  ]
> ...                     libcrypto: [ on  ]
> ...                     libunwind: [ on  ]
> ...            libdw-dwarf-unwind: [ on  ]
> ...                          zlib: [ on  ]
> ...                          lzma: [ on  ]
> ...                     get_cpuid: [ on  ]
> ...                           bpf: [ on  ]
> 
>   GEN      /tmp/build/perf/common-cmds.h
>   CC       /tmp/build/perf/fixdep.o
>   LD       /tmp/build/perf/fixdep-in.o
> <SNIP>
> [acme@jouet linux]$ ldd ~/bin/perf | grep babel
> 	libbabeltrace-ctf.so.1 => /lib64/libbabeltrace-ctf.so.1 (0x00007fce5c405000)
> 	libbabeltrace.so.1 => /lib64/libbabeltrace.so.1 (0x00007fce5bd69000)
> [acme@jouet linux]$ 
> 
> 
> - Arnaldo