From: Florian Westphal <fw@strlen.de>
To: Shivani Bhardwaj <shivanib134@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] src: proto: Add missing packet type
Date: Tue, 1 Mar 2016 14:17:40 +0100 [thread overview]
Message-ID: <20160301131740.GD22817@breakpoint.cc> (raw)
In-Reply-To: <20160301123912.GA6905@gmail.com>
Shivani Bhardwaj <shivanib134@gmail.com> wrote:
> Add missing packet type "invalid" for DCCP.
>
> Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
> ---
> src/proto.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/proto.c b/src/proto.c
> index 0ed98ed..4d049f5 100644
> --- a/src/proto.c
> +++ b/src/proto.c
> @@ -443,6 +443,7 @@ static const struct symbol_table dccp_pkttype_tbl = {
> SYMBOL("reset", DCCP_PKT_RESET),
> SYMBOL("sync", DCCP_PKT_SYNC),
> SYMBOL("syncack", DCCP_PKT_SYNCACK),
> + SYMBOL("invalid", DCCP_PKT_INVALID),
I don't think this is a good idea -- when user asks to match
'invalid' then this will check type == DCCP_PKT_INVALID; however
the correct way would be to ask for type '> synack' (i.e.,
outside of the range of types specified).
next prev parent reply other threads:[~2016-03-01 13:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 12:39 [PATCH] src: proto: Add missing packet type Shivani Bhardwaj
2016-03-01 13:17 ` Florian Westphal [this message]
2016-03-01 13:51 ` Shivani Bhardwaj
2016-03-01 14:01 ` Florian Westphal
2016-03-03 17:58 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160301131740.GD22817@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=shivanib134@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.