From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v2 1/6] drm/atomic: Clean up update_output_state. Date: Tue, 1 Mar 2016 17:16:48 +0200 Message-ID: <20160301151648.GI15993@intel.com> References: <1456303053-28806-1-git-send-email-maarten.lankhorst@linux.intel.com> <1456303053-28806-2-git-send-email-maarten.lankhorst@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1456303053-28806-2-git-send-email-maarten.lankhorst@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBGZWIgMjQsIDIwMTYgYXQgMDk6Mzc6MjhBTSArMDEwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gV2l0aCB0aGUgYWRkaXRpb24gb2YgY3J0Y19zdGF0ZS0+Y29ubmVjdG9yX21h c2sgb3RoZXIgY29ubmVjdG9ycyBmcm9tCj4gZGlmZmVyZW50IGNydGMncyBhcmVuJ3QgbmVlZGVk IGFueSBtb3JlIHRvIGRldGVybWluZSBpZiBhIGNydGMgaGFzCj4gY29ubmVjdG9ycywgc28gb25s eSBjYWxsIGFkZF9hZmZlY3RlZF9jb25uZWN0b3JzIG9uIHRoZSB0YXJnZXQgY3J0Yy4KPiBUaGlz IGFsbG93cyBhIGNsZWFudXAgdG8gZmlyc3QgcmVtb3ZlIGFsbCBjdXJyZW50IGNvbm5lY3RvcnMs IHRoZW4KPiBhZGQgYWxsIHNldC0+Y29ubmVjdG9ycyB0byB0aGUgdGFyZ2V0IGNydGMuCgpUaGUg bmV3IG9yZGVyIG9mIHRoaW5ncyBtYWtlIHNlbnNlIHRvIG1lLgpSZXZpZXdlZC1ieTogVmlsbGUg U3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KCk9uZSB0aGluZyBJIGRp ZCBub3RpY2UgaXMgdGhhdCB3ZSdyZSBub3QgY2xlYXJpbmcgdGhlIHByaW1hcnkgcGxhbmUKY3J0 YyBhbmQgZmIgd2hlbiBhIGNydGMgZ2V0cyBkaXNhYmxlZCBkdWUgdG8gaXRzIGNvbm5lY3Rvcihz KSBnZXR0aW5nCnN0b2xlbi4gV2UgZG8gY2xlYXIgdGhlbSB3aGVuIHRoZSBjcnRjIGlzIGV4cGxp Y2l0bHkgZGlzYWJsZWQuIE5vdCBzdXJlCmlmIHRoYXQgbWF0dGVycyBmb3IgYW55dGhpbmcsIGJ1 dCBpdCBkb2VzIHNlZW0gYSBiaXQgaW5jb25zaXN0ZW50LgoKPiAKPiBTaWduZWQtb2ZmLWJ5OiBN YWFydGVuIExhbmtob3JzdCA8bWFhcnRlbi5sYW5raG9yc3RAbGludXguaW50ZWwuY29tPgo+IC0t LQo+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYyB8IDQxICsrKysrKysrKysr KysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDE3IGluc2VydGlv bnMoKyksIDI0IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v ZHJtX2F0b21pY19oZWxwZXIuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX2hlbHBlci5j Cj4gaW5kZXggNGRhNGYyYTQ5MDc4Li5hMDIyNmQ0Yjk0OWEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVy cy9ncHUvZHJtL2RybV9hdG9taWNfaGVscGVyLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJt X2F0b21pY19oZWxwZXIuYwo+IEBAIC0xNzYxLDI4ICsxNzYxLDE4IEBAIHN0YXRpYyBpbnQgdXBk YXRlX291dHB1dF9zdGF0ZShzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3RhdGUsCj4gIAlzdHJ1 Y3QgZHJtX2NydGNfc3RhdGUgKmNydGNfc3RhdGU7Cj4gIAlzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAq Y29ubmVjdG9yOwo+ICAJc3RydWN0IGRybV9jb25uZWN0b3Jfc3RhdGUgKmNvbm5fc3RhdGU7Cj4g LQlpbnQgcmV0LCBpLCBqOwo+ICsJaW50IHJldCwgaTsKPiAgCj4gIAlyZXQgPSBkcm1fbW9kZXNl dF9sb2NrKCZkZXYtPm1vZGVfY29uZmlnLmNvbm5lY3Rpb25fbXV0ZXgsCj4gIAkJCSAgICAgICBz dGF0ZS0+YWNxdWlyZV9jdHgpOwo+ICAJaWYgKHJldCkKPiAgCQlyZXR1cm4gcmV0Owo+ICAKPiAt CS8qIEZpcnN0IGdyYWIgYWxsIGFmZmVjdGVkIGNvbm5lY3Rvci9jcnRjIHN0YXRlcy4gKi8KPiAt CWZvciAoaSA9IDA7IGkgPCBzZXQtPm51bV9jb25uZWN0b3JzOyBpKyspIHsKPiAtCQljb25uX3N0 YXRlID0gZHJtX2F0b21pY19nZXRfY29ubmVjdG9yX3N0YXRlKHN0YXRlLAo+IC0JCQkJCQkJICAg IHNldC0+Y29ubmVjdG9yc1tpXSk7Cj4gLQkJaWYgKElTX0VSUihjb25uX3N0YXRlKSkKPiAtCQkJ cmV0dXJuIFBUUl9FUlIoY29ubl9zdGF0ZSk7Cj4gLQl9Cj4gLQo+IC0JZm9yX2VhY2hfY3J0Y19p bl9zdGF0ZShzdGF0ZSwgY3J0YywgY3J0Y19zdGF0ZSwgaSkgewo+IC0JCXJldCA9IGRybV9hdG9t aWNfYWRkX2FmZmVjdGVkX2Nvbm5lY3RvcnMoc3RhdGUsIGNydGMpOwo+IC0JCWlmIChyZXQpCj4g LQkJCXJldHVybiByZXQ7Cj4gLQl9Cj4gKwkvKiBGaXJzdCBkaXNhYmxlIGFsbCBjb25uZWN0b3Jz IG9uIHRoZSB0YXJnZXQgY3J0Yy4gKi8KPiArCXJldCA9IGRybV9hdG9taWNfYWRkX2FmZmVjdGVk X2Nvbm5lY3RvcnMoc3RhdGUsIHNldC0+Y3J0Yyk7Cj4gKwlpZiAocmV0KQo+ICsJCXJldHVybiBy ZXQ7Cj4gIAo+IC0JLyogVGhlbiByZWNvbXB1dGUgY29ubmVjdG9yLT5jcnRjIGxpbmtzIGFuZCBj cnRjIGVuYWJsaW5nIHN0YXRlLiAqLwo+ICAJZm9yX2VhY2hfY29ubmVjdG9yX2luX3N0YXRlKHN0 YXRlLCBjb25uZWN0b3IsIGNvbm5fc3RhdGUsIGkpIHsKPiAgCQlpZiAoY29ubl9zdGF0ZS0+Y3J0 YyA9PSBzZXQtPmNydGMpIHsKPiAgCQkJcmV0ID0gZHJtX2F0b21pY19zZXRfY3J0Y19mb3JfY29u bmVjdG9yKGNvbm5fc3RhdGUsCj4gQEAgLTE3OTAsMTYgKzE3ODAsMTkgQEAgc3RhdGljIGludCB1 cGRhdGVfb3V0cHV0X3N0YXRlKHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSwKPiAgCQkJ aWYgKHJldCkKPiAgCQkJCXJldHVybiByZXQ7Cj4gIAkJfQo+ICsJfQo+ICAKPiAtCQlmb3IgKGog PSAwOyBqIDwgc2V0LT5udW1fY29ubmVjdG9yczsgaisrKSB7Cj4gLQkJCWlmIChzZXQtPmNvbm5l Y3RvcnNbal0gPT0gY29ubmVjdG9yKSB7Cj4gLQkJCQlyZXQgPSBkcm1fYXRvbWljX3NldF9jcnRj X2Zvcl9jb25uZWN0b3IoY29ubl9zdGF0ZSwKPiAtCQkJCQkJCQkJc2V0LT5jcnRjKTsKPiAtCQkJ CWlmIChyZXQpCj4gLQkJCQkJcmV0dXJuIHJldDsKPiAtCQkJCWJyZWFrOwo+IC0JCQl9Cj4gLQkJ fQo+ICsJLyogVGhlbiBzZXQgYWxsIGNvbm5lY3RvcnMgZnJvbSBzZXQtPmNvbm5lY3RvcnMgb24g dGhlIHRhcmdldCBjcnRjICovCj4gKwlmb3IgKGkgPSAwOyBpIDwgc2V0LT5udW1fY29ubmVjdG9y czsgaSsrKSB7Cj4gKwkJY29ubl9zdGF0ZSA9IGRybV9hdG9taWNfZ2V0X2Nvbm5lY3Rvcl9zdGF0 ZShzdGF0ZSwKPiArCQkJCQkJCSAgICBzZXQtPmNvbm5lY3RvcnNbaV0pOwo+ICsJCWlmIChJU19F UlIoY29ubl9zdGF0ZSkpCj4gKwkJCXJldHVybiBQVFJfRVJSKGNvbm5fc3RhdGUpOwo+ICsKPiAr CQlyZXQgPSBkcm1fYXRvbWljX3NldF9jcnRjX2Zvcl9jb25uZWN0b3IoY29ubl9zdGF0ZSwKPiAr CQkJCQkJCXNldC0+Y3J0Yyk7Cj4gKwkJaWYgKHJldCkKPiArCQkJcmV0dXJuIHJldDsKPiAgCX0K PiAgCj4gIAlmb3JfZWFjaF9jcnRjX2luX3N0YXRlKHN0YXRlLCBjcnRjLCBjcnRjX3N0YXRlLCBp KSB7Cj4gLS0gCj4gMi4xLjAKPiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwo+IGRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKPiBkcmktZGV2ZWxAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9kcmktZGV2ZWwKCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwgT1RDCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5n IGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVk ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=