diff for duplicates of <20160301152034.GA23985@piout.net> diff --git a/a/1.txt b/N1/1.txt index 13346a0..845cf78 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,73 +1,57 @@ On 01/03/2016 at 15:55:58 +0100, Thierry Reding wrote : > On Tue, Mar 01, 2016 at 06:26:21PM +0530, Sudip Mukherjee wrote: > > We were getting build warning about: -> > drivers/rtc/rtc-vr41xx.c:228:12: warning: =E2=80=98vr41xx_rtc_alarm_irq= -_enable=E2=80=99 +> > drivers/rtc/rtc-vr41xx.c:228:12: warning: ‘vr41xx_rtc_alarm_irq_enable’ > > defined but not used -> >=20 +> > > > The function vr41xx_rtc_alarm_irq_enable() was not used anywhere. -> >=20 +> > > > Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk> > > --- -> >=20 +> > > > build log is at: > > https://travis-ci.org/sudipm-mukherjee/parport/jobs/112780206 -> >=20 +> > > > drivers/rtc/rtc-vr41xx.c | 18 ------------------ > > 1 file changed, 18 deletions(-) -> >=20 +> > > > diff --git a/drivers/rtc/rtc-vr41xx.c b/drivers/rtc/rtc-vr41xx.c > > index f64c282..68cb63e 100644 > > --- a/drivers/rtc/rtc-vr41xx.c > > +++ b/drivers/rtc/rtc-vr41xx.c -> > @@ -225,24 +225,6 @@ static int vr41xx_rtc_ioctl(struct device *dev, un= -signed int cmd, unsigned long +> > @@ -225,24 +225,6 @@ static int vr41xx_rtc_ioctl(struct device *dev, unsigned int cmd, unsigned long > > return 0; > > } -> > =20 -> > -static int vr41xx_rtc_alarm_irq_enable(struct device *dev, unsigned in= -t enabled) +> > +> > -static int vr41xx_rtc_alarm_irq_enable(struct device *dev, unsigned int enabled) > > -{ > > - spin_lock_irq(&rtc_lock); > > - if (enabled) { > > - if (!alarm_enabled) { > > - enable_irq(aie_irq); -> > - alarm_enabled =3D 1; +> > - alarm_enabled = 1; > > - } > > - } else { > > - if (alarm_enabled) { > > - disable_irq(aie_irq); -> > - alarm_enabled =3D 0; +> > - alarm_enabled = 0; > > - } > > - } > > - spin_unlock_irq(&rtc_lock); > > - return 0; > > -} > > - ->=20 +> > I don't think it's supposed to be unused, rather back at the time it > simply wasn't hooked up to the rtc_class_ops. ->=20 +> > Here's what I used. ->=20 +> I've already applied the patch from Geert which does the same. ---=20 +-- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com - ---=20 ---=20 -You received this message because you are subscribed to "rtc-linux". -Membership options at http://groups.google.com/group/rtc-linux . -Please read http://groups.google.com/group/rtc-linux/web/checklist -before submitting a driver. ----=20 -You received this message because you are subscribed to the Google Groups "= -rtc-linux" group. -To unsubscribe from this group and stop receiving emails from it, send an e= -mail to rtc-linux+unsubscribe@googlegroups.com. -For more options, visit https://groups.google.com/d/optout. diff --git a/a/content_digest b/N1/content_digest index 57a4296..1a1b5e1 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,7 @@ "ref\01456836981-30999-1-git-send-email-sudipm.mukherjee@gmail.com\0" "ref\020160301145558.GC26201@ulmo\0" "From\0Alexandre Belloni <alexandre.belloni@free-electrons.com>\0" - "Subject\0[rtc-linux] Re: [PATCH] rtc: rtc-vr41xx: remove unused function\0" + "Subject\0Re: [PATCH] rtc: rtc-vr41xx: remove unused function\0" "Date\0Tue, 1 Mar 2016 16:20:34 +0100\0" "To\0Thierry Reding <thierry.reding@gmail.com>\0" "Cc\0Sudip Mukherjee <sudipm.mukherjee@gmail.com>" @@ -13,75 +13,59 @@ "On 01/03/2016 at 15:55:58 +0100, Thierry Reding wrote :\n" "> On Tue, Mar 01, 2016 at 06:26:21PM +0530, Sudip Mukherjee wrote:\n" "> > We were getting build warning about:\n" - "> > drivers/rtc/rtc-vr41xx.c:228:12: warning: =E2=80=98vr41xx_rtc_alarm_irq=\n" - "_enable=E2=80=99\n" + "> > drivers/rtc/rtc-vr41xx.c:228:12: warning: \342\200\230vr41xx_rtc_alarm_irq_enable\342\200\231\n" "> > defined but not used\n" - "> >=20\n" + "> > \n" "> > The function vr41xx_rtc_alarm_irq_enable() was not used anywhere.\n" - "> >=20\n" + "> > \n" "> > Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>\n" "> > ---\n" - "> >=20\n" + "> > \n" "> > build log is at:\n" "> > https://travis-ci.org/sudipm-mukherjee/parport/jobs/112780206\n" - "> >=20\n" + "> > \n" "> > drivers/rtc/rtc-vr41xx.c | 18 ------------------\n" "> > 1 file changed, 18 deletions(-)\n" - "> >=20\n" + "> > \n" "> > diff --git a/drivers/rtc/rtc-vr41xx.c b/drivers/rtc/rtc-vr41xx.c\n" "> > index f64c282..68cb63e 100644\n" "> > --- a/drivers/rtc/rtc-vr41xx.c\n" "> > +++ b/drivers/rtc/rtc-vr41xx.c\n" - "> > @@ -225,24 +225,6 @@ static int vr41xx_rtc_ioctl(struct device *dev, un=\n" - "signed int cmd, unsigned long\n" + "> > @@ -225,24 +225,6 @@ static int vr41xx_rtc_ioctl(struct device *dev, unsigned int cmd, unsigned long\n" "> > \treturn 0;\n" "> > }\n" - "> > =20\n" - "> > -static int vr41xx_rtc_alarm_irq_enable(struct device *dev, unsigned in=\n" - "t enabled)\n" + "> > \n" + "> > -static int vr41xx_rtc_alarm_irq_enable(struct device *dev, unsigned int enabled)\n" "> > -{\n" "> > -\tspin_lock_irq(&rtc_lock);\n" "> > -\tif (enabled) {\n" "> > -\t\tif (!alarm_enabled) {\n" "> > -\t\t\tenable_irq(aie_irq);\n" - "> > -\t\t\talarm_enabled =3D 1;\n" + "> > -\t\t\talarm_enabled = 1;\n" "> > -\t\t}\n" "> > -\t} else {\n" "> > -\t\tif (alarm_enabled) {\n" "> > -\t\t\tdisable_irq(aie_irq);\n" - "> > -\t\t\talarm_enabled =3D 0;\n" + "> > -\t\t\talarm_enabled = 0;\n" "> > -\t\t}\n" "> > -\t}\n" "> > -\tspin_unlock_irq(&rtc_lock);\n" "> > -\treturn 0;\n" "> > -}\n" "> > -\n" - ">=20\n" + "> \n" "> I don't think it's supposed to be unused, rather back at the time it\n" "> simply wasn't hooked up to the rtc_class_ops.\n" - ">=20\n" + "> \n" "> Here's what I used.\n" - ">=20\n" + "> \n" "\n" "I've already applied the patch from Geert which does the same.\n" "\n" "\n" - "--=20\n" + "-- \n" "Alexandre Belloni, Free Electrons\n" "Embedded Linux, Kernel and Android engineering\n" - "http://free-electrons.com\n" - "\n" - "--=20\n" - "--=20\n" - "You received this message because you are subscribed to \"rtc-linux\".\n" - "Membership options at http://groups.google.com/group/rtc-linux .\n" - "Please read http://groups.google.com/group/rtc-linux/web/checklist\n" - "before submitting a driver.\n" - "---=20\n" - "You received this message because you are subscribed to the Google Groups \"=\n" - "rtc-linux\" group.\n" - "To unsubscribe from this group and stop receiving emails from it, send an e=\n" - "mail to rtc-linux+unsubscribe@googlegroups.com.\n" - For more options, visit https://groups.google.com/d/optout. + http://free-electrons.com -be0886012fb6925fc73012f8ca8e2cbe9c0129c30698b119a44520024f59eb61 +a614d0e40c9b817f6a938f3da3f91e9b93a641e65764223edc07d1d529fa3412
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.