From: Dave Chinner <david@fromorbit.com>
To: zhangaihua1@huawei.com
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] remove warn when bdi is unregisterd in __mark_inode_dirty().
Date: Wed, 2 Mar 2016 08:34:51 +1100 [thread overview]
Message-ID: <20160301213451.GJ30721@dastard> (raw)
In-Reply-To: <1456729434-15737-1-git-send-email-zhangaihua1@huawei.com>
On Mon, Feb 29, 2016 at 03:03:54PM +0800, zhangaihua1@huawei.com wrote:
> From: zhangaihua <zhangaihua1@huawei.com>
>
> When a disk is ejected, we try to do the operation 'ls', it will fails
> because device is gone.
>
> Currently we do a WARN() which does not seem to be the right thing.
> Convert it to a ratelimited kernel warning.
I don't think this is a good idea - the stack trace is required to
determine what code has failed to detect that the device has gone
and is trying to continue onwards without handling errors correctly.
IMO, iterate_dir() should be fixed to do the right thing when
errors have occurred....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2016-03-01 21:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-29 7:03 [PATCH] remove warn when bdi is unregisterd in __mark_inode_dirty() zhangaihua1
2016-03-01 21:34 ` Dave Chinner [this message]
2016-03-15 4:08 ` Zhang AiHua
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160301213451.GJ30721@dastard \
--to=david@fromorbit.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=zhangaihua1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.