From: Joey Hess <id@joeyh.name>
To: Stefan Beller <sbeller@google.com>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: bug: git submodule add fails when .git is a symlink
Date: Tue, 1 Mar 2016 19:14:22 -0400 [thread overview]
Message-ID: <20160301231422.GA3731@kitenet.net> (raw)
In-Reply-To: <CAGZ79kbV9y6nDuBgqLbzQ=xaroG_uF8RF6gqzk=unJ-9rrtvfw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 675 bytes --]
Stefan Beller wrote:
> To elaborate on that: Starting in 2.7 parts of the submodule stuff
> has been rewritten in C, in 2.8 even more and there is more in flight for
> > 2.8.
>
> However your bug is also to be found in 2.6, which doesn't contain any
> recent rewrites, so it is a rather long standing bug, I would presume.
Yes, I saw it with 2.7.0, but I think the user who reported it was on
2.6.
> As a workaround for now:
>
> echo "gitdir: ../gitdir/.git" > .git
Not an option in our particular situation, unfortunately.
I wonder if the miscalculated ../../../somedir could cause git to access
files outside the git repos?
--
see shy jo
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 811 bytes --]
next prev parent reply other threads:[~2016-03-01 23:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 20:42 bug: git submodule add fails when .git is a symlink Joey Hess
2016-03-01 21:39 ` Stefan Beller
2016-03-01 21:49 ` Stefan Beller
2016-03-01 23:14 ` Joey Hess [this message]
2016-03-01 21:50 ` Junio C Hamano
2016-03-01 23:17 ` Joey Hess
2016-03-02 8:49 ` Jeff King
2016-04-20 16:41 ` Stefan Beller
2016-04-20 17:31 ` Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160301231422.GA3731@kitenet.net \
--to=id@joeyh.name \
--cc=git@vger.kernel.org \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.