From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756610AbcCBA5W (ORCPT ); Tue, 1 Mar 2016 19:57:22 -0500 Received: from mail333.us4.mandrillapp.com ([205.201.137.77]:56744 "EHLO mail333.us4.mandrillapp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755893AbcCAX4Y (ORCPT ); Tue, 1 Mar 2016 18:56:24 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; q=dns; s=mandrill; d=linuxfoundation.org; b=bPD+c0uhyzwYXmnB5sH0I26s4eJLzzIw3oipqDVgdOlQdxz0j/xiUAdpcOF+6T5SCBoRnFwXyNRE V+A7KbLNgLsoWudm5TCCglWC04ZBN56v5g7rLE09aHhXgMdkQ1+0PsAgijzUGTLx/pCn+iUm8T70 tWyuIGT9apJqICiwtv0=; From: Greg Kroah-Hartman Subject: [PATCH 4.4 087/342] Btrfs: add missing brelse when superblock checksum fails X-Mailer: git-send-email 2.7.2 To: Cc: Greg Kroah-Hartman , , Anand Jain , David Sterba Message-Id: <20160301234530.795313494@linuxfoundation.org> In-Reply-To: <20160301234527.990448862@linuxfoundation.org> References: <20160301234527.990448862@linuxfoundation.org> X-Report-Abuse: Please forward a copy of this message, including all headers, to abuse@mandrill.com X-Report-Abuse: You can also report abuse here: http://mandrillapp.com/contact/abuse?id=30481620.266f12de36e94f58a9fd51fce9332aff X-Mandrill-User: md_30481620 Date: Tue, 01 Mar 2016 23:54:27 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Anand Jain commit b2acdddfad13c38a1e8b927d83c3cf321f63601a upstream. Looks like oversight, call brelse() when checksum fails. Further down the code, in the non error path, we do call brelse() and so we don't see brelse() in the goto error paths. Signed-off-by: Anand Jain Reviewed-by: David Sterba Signed-off-by: David Sterba Signed-off-by: Greg Kroah-Hartman --- fs/btrfs/disk-io.c | 1 + 1 file changed, 1 insertion(+) --- a/fs/btrfs/disk-io.c +++ b/fs/btrfs/disk-io.c @@ -2667,6 +2667,7 @@ int open_ctree(struct super_block *sb, if (btrfs_check_super_csum(bh->b_data)) { printk(KERN_ERR "BTRFS: superblock checksum mismatch\n"); err = -EINVAL; + brelse(bh); goto fail_alloc; }