Re: [PATCH] Fix unallocated memory access in TPM eventlog code

[Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>]

On Tue, Mar 01, 2016 at 03:03:34PM -0800, Matthew Garrett wrote:
> COmmit 0cc698 added support for handling endian fixups in the event log code
> but broke the binary log file in the process. Keep the endian code, but read
> the event data from the actual event rather than from unallocated RAM.

This patch is doing the same thing?

https://git.kernel.org/cgit/linux/kernel/git/jmorris/linux-security.git/commit/drivers/char/tpm/tpm_eventlog.c?h=next&id=186d124f07da193a8f47e491af85cb695d415f2f

Already on it's way to mainline.

> -	for (i = 0; i < sizeof(struct tcpa_event) + temp_event.event_size; i++)
> +	for (i = 0; i < sizeof(struct tcpa_event); i++)
> +		seq_putc(m, tempPtr[i]);
> +
> +	tempPtr = (char *)&event->event_data;
> +
> +	for (i = 0; i < temp_event.event_size; i++)
>  		seq_putc(m, tempPtr[i]);

Though this does look more elegant.

Jason

------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140