From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51809)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peterx@redhat.com>) id 1aayoj-0001Jc-BB
	for qemu-devel@nongnu.org; Tue, 01 Mar 2016 23:55:22 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peterx@redhat.com>) id 1aayoe-0000AF-DR
	for qemu-devel@nongnu.org; Tue, 01 Mar 2016 23:55:21 -0500
Received: from mx1.redhat.com ([209.132.183.28]:34491)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peterx@redhat.com>) id 1aayoe-0000AB-8n
	for qemu-devel@nongnu.org; Tue, 01 Mar 2016 23:55:16 -0500
Date: Wed, 2 Mar 2016 12:55:02 +0800
From: Peter Xu <peterx@redhat.com>
Message-ID: <20160302045502.GB5730@pxdev.xzpeter.org>
References: <1456224728-28163-1-git-send-email-peterx@redhat.com>
	<1456224728-28163-2-git-send-email-peterx@redhat.com>
	<56D5C74F.5040305@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <56D5C74F.5040305@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/3] arm: gic: add GICType
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: wei@redhat.com, peter.maydell@linaro.org, drjones@redhat.com, mdroth@linux.vnet.ibm.com, qemu-devel@nongnu.org, armbru@redhat.com, abologna@redhat.com

On Tue, Mar 01, 2016 at 09:46:07AM -0700, Eric Blake wrote:
> On 02/23/2016 03:52 AM, Peter Xu wrote:
> > A new enum type is added to define ARM GIC types.
> > 
> > Signed-off-by: Peter Xu <peterx@redhat.com>
> > ---
> >  qapi-schema.json | 17 +++++++++++++++++
> >  1 file changed, 17 insertions(+)
> > 
> > diff --git a/qapi-schema.json b/qapi-schema.json
> > index 8d04897..81654bd 100644
> > --- a/qapi-schema.json
> > +++ b/qapi-schema.json
> > @@ -4083,3 +4083,20 @@
> >  ##
> >  { 'enum': 'ReplayMode',
> >    'data': [ 'none', 'record', 'play' ] }
> > +
> > +##
> > +# @GICType:
> > +#
> > +# An enumeration of GIC types
> 
> Worth spelling out the acronym?

Sure. I can do it in next spin. 

> 
> > +#
> > +# @gicv2:     GICv2 support without kernel irqchip
> > +#
> > +# @gicv3:     GICv3 support without kernel irqchip
> > +#
> > +# @gicv2-kvm: GICv3 support with kernel irqchip
> 
> Doc typo, should be GICv2

Will fix. If dict to be used finally, will rework as a whole.

Thanks!
Peter