From: Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>
To: "Chalamarla,
Tirumalesh"
<Tirumalesh.Chalamarla-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org>
Cc: "mark.rutland-5wv7dgnIgG8@public.gmane.org"
<mark.rutland-5wv7dgnIgG8@public.gmane.org>,
"Akula,
Geethasowjanya"
<Geethasowjanya.Akula-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org>,
"iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org"
<iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: [PATCH] iommu/arm-smmu-v2: Workaround for ThunderX errata#27704
Date: Wed, 2 Mar 2016 13:35:01 +0000 [thread overview]
Message-ID: <20160302133457.GD7637@arm.com> (raw)
In-Reply-To: <C2D36A36-8247-4432-BE50-14129D9D8E5B-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org>
On Wed, Mar 02, 2016 at 03:23:57AM +0000, Chalamarla, Tirumalesh wrote:
> On 3/1/16, 7:07 PM, "Will Deacon" <will.deacon-5wv7dgnIgG8@public.gmane.org> wrote:
> >On Wed, Feb 24, 2016 at 01:13:53PM -0800, Tirumalesh Chalamarla wrote:
> >> + smmu->cavium_smmu_id = cavium_smmu_count;
> >> + cavium_smmu_count++;
> >> + smmu->cavium_id_base =
> >> + (smmu->cavium_smmu_id * ARM_SMMU_MAX_CBS);
> >
> >Can you not use num_context_banks here, instead of the constant?
> We need total context banks so far, so ARM_SMMU_MAX_CBS is best option.
> For Thunder both are same anyway.
Hmm, so couldn't you instead just update a running total as you go along?
That is, initialise it to zero, then atomic_add_return(num_context_banks)
when you probe?
Will
WARNING: multiple messages have this Message-ID (diff)
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] iommu/arm-smmu-v2: Workaround for ThunderX errata#27704
Date: Wed, 2 Mar 2016 13:35:01 +0000 [thread overview]
Message-ID: <20160302133457.GD7637@arm.com> (raw)
In-Reply-To: <C2D36A36-8247-4432-BE50-14129D9D8E5B@caviumnetworks.com>
On Wed, Mar 02, 2016 at 03:23:57AM +0000, Chalamarla, Tirumalesh wrote:
> On 3/1/16, 7:07 PM, "Will Deacon" <will.deacon@arm.com> wrote:
> >On Wed, Feb 24, 2016 at 01:13:53PM -0800, Tirumalesh Chalamarla wrote:
> >> + smmu->cavium_smmu_id = cavium_smmu_count;
> >> + cavium_smmu_count++;
> >> + smmu->cavium_id_base =
> >> + (smmu->cavium_smmu_id * ARM_SMMU_MAX_CBS);
> >
> >Can you not use num_context_banks here, instead of the constant?
> We need total context banks so far, so ARM_SMMU_MAX_CBS is best option.
> For Thunder both are same anyway.
Hmm, so couldn't you instead just update a running total as you go along?
That is, initialise it to zero, then atomic_add_return(num_context_banks)
when you probe?
Will
next prev parent reply other threads:[~2016-03-02 13:35 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-24 21:13 [PATCH] iommu/arm-smmu-v2: Workaround for ThunderX errata#27704 Tirumalesh Chalamarla
2016-02-24 21:13 ` Tirumalesh Chalamarla
[not found] ` <1456348433-3337-1-git-send-email-tchalamarla-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org>
2016-03-02 3:07 ` Will Deacon
2016-03-02 3:07 ` Will Deacon
[not found] ` <20160302030756.GC7637-5wv7dgnIgG8@public.gmane.org>
2016-03-02 3:23 ` Chalamarla, Tirumalesh
2016-03-02 3:23 ` Chalamarla, Tirumalesh
[not found] ` <C2D36A36-8247-4432-BE50-14129D9D8E5B-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org>
2016-03-02 13:35 ` Will Deacon [this message]
2016-03-02 13:35 ` Will Deacon
2016-03-02 13:10 ` Robin Murphy
2016-03-02 13:10 ` Robin Murphy
[not found] ` <56D6E658.1060201-5wv7dgnIgG8@public.gmane.org>
2016-03-02 18:12 ` Tirumalesh Chalamarla
2016-03-02 18:12 ` Tirumalesh Chalamarla
-- strict thread matches above, loose matches on Subject: below --
2016-02-05 18:47 tchalamarla-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8
2016-02-05 18:47 ` tchalamarla at caviumnetworks.com
[not found] ` <1454698027-20911-1-git-send-email-tchalamarla-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org>
2016-02-05 20:02 ` Mark Rutland
2016-02-05 20:02 ` Mark Rutland
2016-02-05 20:15 ` Mark Rutland
2016-02-05 20:15 ` Mark Rutland
2016-02-05 20:29 ` Chalamarla, Tirumalesh
2016-02-05 20:29 ` Chalamarla, Tirumalesh
2016-02-05 20:32 ` Chalamarla, Tirumalesh
2016-02-05 20:32 ` Chalamarla, Tirumalesh
2016-02-09 11:52 ` Robin Murphy
2016-02-09 11:52 ` Robin Murphy
[not found] ` <56B9D2F4.8070308-5wv7dgnIgG8@public.gmane.org>
2016-02-09 17:07 ` Chalamarla, Tirumalesh
2016-02-09 17:07 ` Chalamarla, Tirumalesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160302133457.GD7637@arm.com \
--to=will.deacon-5wv7dgnigg8@public.gmane.org \
--cc=Geethasowjanya.Akula-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org \
--cc=Tirumalesh.Chalamarla-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.