From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joerg Roedel Date: Wed, 02 Mar 2016 13:53:52 +0000 Subject: Re: [patch 1/2] iommu/mediatek: signedness bug in probe function Message-Id: <20160302135351.GC20213@8bytes.org> List-Id: References: <20160302101006.GF5533@mwanda> In-Reply-To: <20160302101006.GF5533@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Matthias Brugger On Wed, Mar 02, 2016 at 01:10:06PM +0300, Dan Carpenter wrote: > "larb_nr" needs to be signed for the error handling to work. "i" can > be int as well. > > Fixes: 0df4fabe208d ('iommu/mediatek: Add mt8173 IOMMU driver') > Signed-off-by: Dan Carpenter > > diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c > index 721ffdb..1a4022c 100644 > --- a/drivers/iommu/mtk_iommu.c > +++ b/drivers/iommu/mtk_iommu.c > @@ -578,7 +578,7 @@ static int mtk_iommu_probe(struct platform_device *pdev) > struct resource *res; > struct component_match *match = NULL; > void *protect; > - unsigned int i, larb_nr; > + int i, larb_nr; > int ret; > > data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL); I merged a similar fix from Andrzej Hajda yesterday. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joerg Roedel Subject: Re: [patch 1/2] iommu/mediatek: signedness bug in probe function Date: Wed, 2 Mar 2016 14:53:52 +0100 Message-ID: <20160302135351.GC20213@8bytes.org> References: <20160302101006.GF5533@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20160302101006.GF5533@mwanda> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Dan Carpenter Cc: kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Matthias Brugger List-Id: iommu@lists.linux-foundation.org On Wed, Mar 02, 2016 at 01:10:06PM +0300, Dan Carpenter wrote: > "larb_nr" needs to be signed for the error handling to work. "i" can > be int as well. > > Fixes: 0df4fabe208d ('iommu/mediatek: Add mt8173 IOMMU driver') > Signed-off-by: Dan Carpenter > > diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c > index 721ffdb..1a4022c 100644 > --- a/drivers/iommu/mtk_iommu.c > +++ b/drivers/iommu/mtk_iommu.c > @@ -578,7 +578,7 @@ static int mtk_iommu_probe(struct platform_device *pdev) > struct resource *res; > struct component_match *match = NULL; > void *protect; > - unsigned int i, larb_nr; > + int i, larb_nr; > int ret; > > data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL); I merged a similar fix from Andrzej Hajda yesterday. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753184AbcCBNx4 (ORCPT ); Wed, 2 Mar 2016 08:53:56 -0500 Received: from 8bytes.org ([81.169.241.247]:47936 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753004AbcCBNxy (ORCPT ); Wed, 2 Mar 2016 08:53:54 -0500 Date: Wed, 2 Mar 2016 14:53:52 +0100 From: Joerg Roedel To: Dan Carpenter Cc: Yong Wu , Matthias Brugger , iommu@lists.linux-foundation.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [patch 1/2] iommu/mediatek: signedness bug in probe function Message-ID: <20160302135351.GC20213@8bytes.org> References: <20160302101006.GF5533@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160302101006.GF5533@mwanda> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 02, 2016 at 01:10:06PM +0300, Dan Carpenter wrote: > "larb_nr" needs to be signed for the error handling to work. "i" can > be int as well. > > Fixes: 0df4fabe208d ('iommu/mediatek: Add mt8173 IOMMU driver') > Signed-off-by: Dan Carpenter > > diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c > index 721ffdb..1a4022c 100644 > --- a/drivers/iommu/mtk_iommu.c > +++ b/drivers/iommu/mtk_iommu.c > @@ -578,7 +578,7 @@ static int mtk_iommu_probe(struct platform_device *pdev) > struct resource *res; > struct component_match *match = NULL; > void *protect; > - unsigned int i, larb_nr; > + int i, larb_nr; > int ret; > > data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL); I merged a similar fix from Andrzej Hajda yesterday.