From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joerg Roedel Date: Wed, 02 Mar 2016 14:53:55 +0000 Subject: Re: [patch] iommu/exynos: checking for IS_ERR() instead of NULL Message-Id: <20160302145355.GE20213@8bytes.org> List-Id: References: <20160302101047.GH5533@mwanda> In-Reply-To: <20160302101047.GH5533@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: Krzysztof Kozlowski , linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Kukjin Kim On Wed, Mar 02, 2016 at 01:10:47PM +0300, Dan Carpenter wrote: > of_platform_device_create() returns NULL on error, it never returns > error pointers. > > Fixes: 8ed55c812fa8 ('iommu/exynos: Init from dt-specific callback instead of initcall') > Signed-off-by: Dan Carpenter Applied, thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joerg Roedel Subject: Re: [patch] iommu/exynos: checking for IS_ERR() instead of NULL Date: Wed, 2 Mar 2016 15:53:55 +0100 Message-ID: <20160302145355.GE20213@8bytes.org> References: <20160302101047.GH5533@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20160302101047.GH5533@mwanda> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Dan Carpenter Cc: Krzysztof Kozlowski , linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Kukjin Kim List-Id: iommu@lists.linux-foundation.org On Wed, Mar 02, 2016 at 01:10:47PM +0300, Dan Carpenter wrote: > of_platform_device_create() returns NULL on error, it never returns > error pointers. > > Fixes: 8ed55c812fa8 ('iommu/exynos: Init from dt-specific callback instead of initcall') > Signed-off-by: Dan Carpenter Applied, thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753177AbcCBOyA (ORCPT ); Wed, 2 Mar 2016 09:54:00 -0500 Received: from 8bytes.org ([81.169.241.247]:48562 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750745AbcCBOx6 (ORCPT ); Wed, 2 Mar 2016 09:53:58 -0500 Date: Wed, 2 Mar 2016 15:53:55 +0100 From: Joerg Roedel To: Dan Carpenter Cc: Marek Szyprowski , Kukjin Kim , Krzysztof Kozlowski , iommu@lists.linux-foundation.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [patch] iommu/exynos: checking for IS_ERR() instead of NULL Message-ID: <20160302145355.GE20213@8bytes.org> References: <20160302101047.GH5533@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160302101047.GH5533@mwanda> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 02, 2016 at 01:10:47PM +0300, Dan Carpenter wrote: > of_platform_device_create() returns NULL on error, it never returns > error pointers. > > Fixes: 8ed55c812fa8 ('iommu/exynos: Init from dt-specific callback instead of initcall') > Signed-off-by: Dan Carpenter Applied, thanks.