All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org,
	linux-rt-users <linux-rt-users@vger.kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Carsten Emde <C.Emde@osadl.org>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	John Kacur <jkacur@redhat.com>,
	Paul Gortmaker <paul.gortmaker@windriver.com>
Subject: [PATCH RT 05/10] kernel: softirq: unlock with irqs on
Date: Wed, 02 Mar 2016 10:51:05 -0500	[thread overview]
Message-ID: <20160302155111.192159170@goodmis.org> (raw)
In-Reply-To: 20160302155100.873557484@goodmis.org

[-- Attachment #1: 0005-kernel-softirq-unlock-with-irqs-on.patch --]
[-- Type: text/plain, Size: 984 bytes --]

3.10.97-rt107-rc1 stable review patch.
If anyone has any objections, please let me know.

------------------

From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>

We unlock the lock while the interrupts are off. This isn't a problem
now but will get because the migrate_disable() + enable are not
symmetrical in regard to the status of interrupts.

Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
 kernel/softirq.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/kernel/softirq.c b/kernel/softirq.c
index ce2cfd3910d4..463523131bfa 100644
--- a/kernel/softirq.c
+++ b/kernel/softirq.c
@@ -580,8 +580,10 @@ static void do_current_softirqs(int need_rcu_bh_qs)
 			do_single_softirq(i, need_rcu_bh_qs);
 		}
 		softirq_clr_runner(i);
-		unlock_softirq(i);
 		WARN_ON(current->softirq_nestcnt != 1);
+		local_irq_enable();
+		unlock_softirq(i);
+		local_irq_disable();
 	}
 }
 
-- 
2.7.0

  parent reply	other threads:[~2016-03-02 15:51 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-02 15:51 [PATCH RT 00/10] Linux 3.10.97-rt107-rc1 Steven Rostedt
2016-03-02 15:51 ` [PATCH RT 01/10] softirq: split timer softirqs out of ksoftirqd Steven Rostedt
2016-03-02 15:51 ` [PATCH RT 02/10] net: provide a way to delegate processing a softirq to ksoftirqd Steven Rostedt
2016-03-02 15:51 ` [PATCH RT 03/10] latencyhist: disable jump-labels Steven Rostedt
2016-03-02 15:51 ` [PATCH RT 04/10] kernel: migrate_disable() do fastpath in atomic & irqs-off Steven Rostedt
2016-03-02 15:51 ` Steven Rostedt [this message]
2016-03-02 15:51 ` [PATCH RT 06/10] kernel/stop_machine: partly revert "stop_machine: Use raw spinlocks" Steven Rostedt
2016-03-02 15:51 ` [PATCH RT 07/10] trace: Use rcuidle version for preemptoff_hist trace point Steven Rostedt
2016-03-02 15:51 ` [PATCH RT 08/10] rcu/torture: Comment out rcu_bh ops on PREEMPT_RT_FULL Steven Rostedt
2016-03-02 15:51 ` [PATCH RT 09/10] kernel: sched: Fix preempt_disable_ip recodring for preempt_disable() Steven Rostedt
2016-03-02 15:51 ` [PATCH RT 10/10] Linux 3.10.97-rt107-rc1 Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160302155111.192159170@goodmis.org \
    --to=rostedt@goodmis.org \
    --cc=C.Emde@osadl.org \
    --cc=bigeasy@linutronix.de \
    --cc=jkacur@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=paul.gortmaker@windriver.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.