From: Borislav Petkov <bp@alien8.de>
To: Brian Gerst <brgerst@gmail.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>, X86 ML <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [RFC PATCH] x86: Make sure verify_cpu has a good stack
Date: Wed, 2 Mar 2016 17:25:30 +0100 [thread overview]
Message-ID: <20160302162530.GA8362@pd.tnic> (raw)
In-Reply-To: <CAMzpN2jsSaQDtnMSbPq7W5GY_1WUmjts9-9kq45E29=nXAV7rw@mail.gmail.com>
On Wed, Mar 02, 2016 at 11:22:30AM -0500, Brian Gerst wrote:
> This should be: movq stack_start(%rip), %rsp
No it wouldn't. That doesn't work.
> > + subq $__START_KERNEL_map, %rsp
>
> It would be better to add the offset to the initializer for
> stack_start instead of adjusting it at runtime. That would require
> moving the existing load of stack_start from the common path to the
> secondary startup,
This is the BSP we're talking about - no secondary startup. We want to run
verify_cpu as early as possible.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
next prev parent reply other threads:[~2016-03-02 16:25 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-02 11:20 [RFC PATCH] x86: Make sure verify_cpu has a good stack Borislav Petkov
2016-03-02 15:55 ` Mika Penttilä
2016-03-02 16:15 ` Borislav Petkov
2016-03-02 16:38 ` Mika Penttilä
2016-03-02 16:55 ` Borislav Petkov
2016-03-02 17:44 ` Mika Penttilä
2016-03-02 16:22 ` Brian Gerst
2016-03-02 16:25 ` Borislav Petkov [this message]
2016-03-02 17:53 ` H. Peter Anvin
2016-03-02 18:15 ` Borislav Petkov
2016-03-02 18:25 ` H. Peter Anvin
2016-03-02 18:39 ` H. Peter Anvin
2016-03-02 19:50 ` Borislav Petkov
2016-03-02 20:46 ` Borislav Petkov
2016-03-02 21:35 ` H. Peter Anvin
2016-03-02 21:46 ` Borislav Petkov
2016-03-02 21:54 ` H. Peter Anvin
2016-03-02 22:09 ` Borislav Petkov
2016-03-02 22:11 ` H. Peter Anvin
2016-03-02 22:28 ` Borislav Petkov
2016-03-02 22:32 ` H. Peter Anvin
2016-03-02 22:40 ` Borislav Petkov
2016-03-03 0:13 ` Yinghai Lu
2016-03-03 1:00 ` Yinghai Lu
2016-03-03 2:50 ` Yinghai Lu
2016-03-03 12:28 ` Borislav Petkov
2016-03-03 15:26 ` H. Peter Anvin
2016-03-03 16:29 ` Borislav Petkov
2016-03-03 20:22 ` H. Peter Anvin
2016-03-03 20:54 ` Borislav Petkov
2016-03-03 21:22 ` H. Peter Anvin
2016-03-03 21:38 ` Borislav Petkov
2016-03-04 1:18 ` Yinghai Lu
2016-03-04 2:25 ` Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160302162530.GA8362@pd.tnic \
--to=bp@alien8.de \
--cc=brgerst@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.