Re: clk: ti: Add support for dm814x ADPLL

[Tony Lindgren <tony@atomide.com>]

* Dan Carpenter <dan.carpenter@oracle.com> [160302 10:09]:
> On Wed, Mar 02, 2016 at 09:05:03AM -0800, Tony Lindgren wrote:
> > >    910          err = ti_adpll_init_registers(d);
> > >    911          if (err)
> > >    912                  return err;
> > >    913  
> > >    914          err = ti_adpll_init_inputs(d);
> > >    915          if (err)
> > >    916                  return err;
> > >                         ^^^^^^^^^^
> > > This is the last direct return in the function, meaning that
> > > ti_adpll_init_inputs() must allocate something but I can't see what.
> > > It should match clkdev_drop() and ac->unregister()?  I don't understand.
> > 
> > Hmm I don't get this one. How did you get a warning here, is this a
> > warning from sparse also?
> 
> There isn't a warning here.  I'm just saying that when I'm reading this
> code I assume that ti_adpll_free_resources() is supposed to undo
> ti_adpll_init_inputs().
>
> I looked at Steven's patch and now I see what's going on here.  The
> error handling is fine when that's applied.  Thanks.

OK thanks for checking.

Regards,

Tony