From: "Michael S. Tsirkin" <mst@redhat.com>
To: "Cédric Le Goater" <clg@fr.ibm.com>
Cc: Marcel Apfelbaum <marcel@redhat.com>,
Corey Minyard <cminyard@mvista.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 02/10] ipmi: replace IPMI_ADD_RSP_DATA() macro with inline helpers
Date: Wed, 2 Mar 2016 20:02:20 +0200 [thread overview]
Message-ID: <20160302200147-mutt-send-email-mst@redhat.com> (raw)
In-Reply-To: <56D72884.6050501@fr.ibm.com>
On Wed, Mar 02, 2016 at 06:53:08PM +0100, Cédric Le Goater wrote:
> > typedef struct RspBuffer RspBuffer;
>
> OK. So that's the rule for structs in qemu. It is not that clear
> when you look at the code around. I will change. np.
Did you look at CODING_STYLE? Pls do.
next prev parent reply other threads:[~2016-03-02 18:02 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-02 10:14 [Qemu-devel] [PATCH v2 00/10] ipmi: a couple of enhancements to the BMC simulator (round 2) Cédric Le Goater
2016-03-02 10:14 ` [Qemu-devel] [PATCH v2 01/10] ipmi: remove IPMI_CHECK_CMD_LEN() macro Cédric Le Goater
2016-03-05 11:41 ` Corey Minyard
2016-03-07 10:40 ` Cédric Le Goater
2016-03-08 17:06 ` Cédric Le Goater
2016-03-09 4:07 ` Corey Minyard
2016-03-09 8:52 ` Cédric Le Goater
2016-03-02 10:14 ` [Qemu-devel] [PATCH v2 02/10] ipmi: replace IPMI_ADD_RSP_DATA() macro with inline helpers Cédric Le Goater
2016-03-02 10:25 ` Michael S. Tsirkin
2016-03-02 17:53 ` Cédric Le Goater
2016-03-02 18:02 ` Michael S. Tsirkin [this message]
2016-03-02 18:08 ` Cédric Le Goater
2016-03-05 11:41 ` Corey Minyard
2016-03-02 10:14 ` [Qemu-devel] [PATCH v2 03/10] ipmi: remove IPMI_CHECK_RESERVATION() macro Cédric Le Goater
2016-03-02 15:40 ` Corey Minyard
2016-03-02 10:14 ` [Qemu-devel] [PATCH v2 04/10] ipmi: add rsp_buffer_set_error() helper Cédric Le Goater
2016-03-05 11:42 ` Corey Minyard
2016-03-02 10:14 ` [Qemu-devel] [PATCH v2 05/10] ipmi: add a realize function to the device class Cédric Le Goater
2016-03-02 10:14 ` [Qemu-devel] [PATCH v2 06/10] ipmi: use a function to initialize the SDR table Cédric Le Goater
2016-03-02 10:14 ` [Qemu-devel] [PATCH v2 07/10] ipmi: remove the need of an ending record in " Cédric Le Goater
2016-03-02 10:14 ` [Qemu-devel] [PATCH v2 08/10] ipmi: add some local variables in ipmi_sdr_init Cédric Le Goater
2016-03-02 10:14 ` [Qemu-devel] [PATCH v2 09/10] ipmi: use a file to load SDRs Cédric Le Goater
2016-03-02 10:14 ` [Qemu-devel] [PATCH v2 10/10] ipmi: provide support for FRUs Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160302200147-mutt-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=clg@fr.ibm.com \
--cc=cminyard@mvista.com \
--cc=marcel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.