From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 1/5] nvme: also set BLK_MQ_F_SHOULD_MERGE for the admin queue
Date: Wed, 2 Mar 2016 22:17:29 +0100 [thread overview]
Message-ID: <20160302211729.GA3803@lst.de> (raw)
In-Reply-To: <56D7247C.4000208@dev.mellanox.co.il>
On Wed, Mar 02, 2016@07:35:56PM +0200, Sagi Grimberg wrote:
>> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
>> index 680f578..19be56a 100644
>> --- a/drivers/nvme/host/pci.c
>> +++ b/drivers/nvme/host/pci.c
>> @@ -1289,6 +1289,7 @@ static int nvme_alloc_admin_tags(struct nvme_dev *dev)
>> dev->admin_tagset.timeout = ADMIN_TIMEOUT;
>> dev->admin_tagset.numa_node = dev_to_node(dev->dev);
>> dev->admin_tagset.cmd_size = nvme_cmd_size(dev);
>> + dev->admin_tagset.flags = BLK_MQ_F_SHOULD_MERGE;
>
> I still don't understand what's the point?
still? :)
But yes, we're not going to hit the merge case for the passthrough
command indeed. Except for keeping the flags in sync, which sounds
like a good ?dea in general there is not reall need for this one.
next prev parent reply other threads:[~2016-03-02 21:17 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-02 17:07 [for 4.5] fix regression for large NVMe user command Christoph Hellwig
2016-03-02 17:07 ` [PATCH 1/5] nvme: also set BLK_MQ_F_SHOULD_MERGE for the admin queue Christoph Hellwig
2016-03-02 17:35 ` Sagi Grimberg
2016-03-02 18:15 ` Keith Busch
2016-03-02 21:17 ` Christoph Hellwig [this message]
2016-03-02 23:55 ` Ming Lei
[not found] ` <20160303084609.GA14051@lst.de>
2016-03-03 11:24 ` blk-mq merge flags Ming Lei
2016-03-03 11:59 ` Christoph Hellwig
2016-03-15 16:08 ` Christoph Hellwig
2016-03-15 22:13 ` Jens Axboe
2016-03-02 20:01 ` [PATCH 1/5] nvme: also set BLK_MQ_F_SHOULD_MERGE for the admin queue Jens Axboe
2016-03-02 17:07 ` [PATCH 2/5] nvme: set queue limits " Christoph Hellwig
2016-03-02 19:10 ` Keith Busch
2016-03-02 17:07 ` [PATCH 3/5] nvme: fix max_segments integer truncation Christoph Hellwig
2016-03-02 18:27 ` Keith Busch
2016-03-02 17:07 ` [PATCH 4/5] block: fix blk_rq_get_max_sectors for driver private requests Christoph Hellwig
2016-03-02 19:17 ` Keith Busch
2016-03-02 21:18 ` Christoph Hellwig
2016-03-02 22:16 ` Jens Axboe
2016-03-02 17:07 ` [PATCH 5/5] block: support large requests in blk_rq_map_user_iov Christoph Hellwig
2016-03-02 19:34 ` Keith Busch
2016-03-02 21:20 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160302211729.GA3803@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.