All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jin Qian <jinqian@android.com>
Cc: linux-kernel@vger.kernel.org, jsharkey@google.com,
	digit@google.com, pprabhu@google.com, Yu Ning <yu.ning@intel.com>
Subject: Re: allocate an official device major number for virtio device?
Date: Wed, 2 Mar 2016 17:25:30 -0800	[thread overview]
Message-ID: <20160303012530.GA23521@kroah.com> (raw)
In-Reply-To: <CA+yUs=xdYodxX8g+uiw+r+V1wSfDukXGP7X7mBUGwDK=c-pP-Q@mail.gmail.com>

On Wed, Mar 02, 2016 at 05:08:00PM -0800, Jin Qian wrote:
> Hi -
> 
> Can we allocate an official device major number for virtio devices?
> Currently it's using 240-254 (LOCAL/EXPERIMENTAL USE). The reason we
> ask for this is because userspace will need to treat virtio block
> devices differently and need a way to detect such device. For example,
> it checks major number to detect scsi and mmc device.
> 
> https://android-review.googlesource.com/#/c/195240
> 
> With dynamic major numbers 240-254, we might treat other devices as
> virtio block device incorrectly.

You shouldn't treat them incorrectly, devtmpfs handles this for you
automatically, so I'd recommend using the dynamic majors please.

And what in-kernel code is using the "experimental" range today?  Do you
have a pointer to that?  We should fix that now...

thanks,

greg k-h

  reply	other threads:[~2016-03-03  1:25 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-03  1:08 allocate an official device major number for virtio device? Jin Qian
2016-03-03  1:25 ` Greg Kroah-Hartman [this message]
2016-03-03  1:48   ` Jin Qian
2016-03-03  3:52     ` Ning, Yu
2016-03-03 14:46       ` One Thousand Gnomes
2016-03-03 17:18       ` Greg Kroah-Hartman
2016-03-03 19:32         ` Jin Qian
2016-03-03 20:00           ` Greg Kroah-Hartman
2016-03-03 22:12             ` Jeff Sharkey
2016-03-03 22:35               ` Richard Weinberger
2016-03-03 22:43               ` Greg Kroah-Hartman
2016-03-03 17:17     ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160303012530.GA23521@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=digit@google.com \
    --cc=jinqian@android.com \
    --cc=jsharkey@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pprabhu@google.com \
    --cc=yu.ning@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.