From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Jones Subject: Re: [kvm-unit-tests v2 7/8] lib: dump stack on abort() Date: Thu, 3 Mar 2016 10:19:06 +0100 Message-ID: <20160303091906.GB1515@localhost.redhat.com> References: <1456867658-10937-1-git-send-email-pfeiner@google.com> <1456967378-6367-1-git-send-email-pfeiner@google.com> <1456967378-6367-8-git-send-email-pfeiner@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, pbonzini@redhat.com To: Peter Feiner Return-path: Received: from mx1.redhat.com ([209.132.183.28]:38571 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756689AbcCCJTM (ORCPT ); Thu, 3 Mar 2016 04:19:12 -0500 Content-Disposition: inline In-Reply-To: <1456967378-6367-8-git-send-email-pfeiner@google.com> Sender: kvm-owner@vger.kernel.org List-ID: Looks like you forgot to update $SUBJECT; s/abort/assert/ drew On Wed, Mar 02, 2016 at 05:09:37PM -0800, Peter Feiner wrote: > Signed-off-by: Peter Feiner > --- > lib/libcflat.h | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/lib/libcflat.h b/lib/libcflat.h > index 42c94df..1798716 100644 > --- a/lib/libcflat.h > +++ b/lib/libcflat.h > @@ -77,10 +77,12 @@ void dump_current_stack(void); > > #define assert(cond) \ > do { \ > - if (!(cond)) \ > + if (!(cond)) { \ > printf("%s:%d: assert failed: %s\n", \ > - __FILE__, __LINE__, #cond), \ > + __FILE__, __LINE__, #cond); \ > + dump_current_stack(); \ > abort(); \ > + } \ > } while (0) > > #endif > -- > 2.7.0.rc3.207.g0ac5344 > > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html