From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vinod Koul Subject: Re: [PATCH v2 5/7] ALSA: hda - Use ops instead of directly accessing chmap helpers Date: Thu, 3 Mar 2016 16:59:23 +0530 Message-ID: <20160303112923.GK11154@localhost> References: <1456920208-1172-1-git-send-email-subhransu.s.prusty@intel.com> <1456920208-1172-6-git-send-email-subhransu.s.prusty@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by alsa0.perex.cz (Postfix) with ESMTP id 15B2E26519F for ; Thu, 3 Mar 2016 12:25:45 +0100 (CET) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Takashi Iwai Cc: patches.audio@intel.com, alsa-devel@alsa-project.org, broonie@kernel.org, "Subhransu S. Prusty" , lgirdwood@gmail.com List-Id: alsa-devel@alsa-project.org On Wed, Mar 02, 2016 at 05:03:10PM +0100, Takashi Iwai wrote: > On Wed, 02 Mar 2016 13:03:26 +0100, > Subhransu S. Prusty wrote: > > > > Added more ops to the chmap object, so most of the helpers can be > > accessed through ops instead instead of directly calling them. > > Too many instead :) > > > With this moving the chmap helpers to core will be easy. > > Well, although I asked about reduction of exported stuff, I don't > think it's worth to put everything in ops. If any of them would be > overridden, it's good to have as an ops. If not, it's fine to have > exported symbols. These are just a few entries, not over 20. I think the thought was that patch_hdmi and ASoC driver will use defaults whereas the patch_nvidia etc will override with their own stuff.. -- ~Vinod