Re: [PATCH v2] ASoC: cht_bsw_rt5645: Fix writing to string literal

[Vinod Koul <vinod.koul@intel.com>]

[-- Attachment #1.1: Type: text/plain, Size: 905 bytes --]

On Fri, Feb 26, 2016 at 11:12:10AM +0900, Mark Brown wrote:
> On Tue, Feb 23, 2016 at 09:50:20AM +0100, Carlo Caione wrote:
> > From: Carlo Caione <carlo@endlessm.com>
> > 
> > We cannot use strcpy() to write to a const char * location. This is
> > causing a 'BUG: unable to handle kernel paging request' error at boot
> > when using the cht-bsw-rt5645 driver.
> > 
> > With this patch we also fix a wrong indexing in the driver where the
> > codec_name of the wrong dai_link is being overwritten.
> 
> So how was the original code tested then...?

I know systems using this are shipping so surprised to see this.

Carlo cna you please tell me the configuration where it is seen.

Also would be worth mentioning here that Pierre is working on a super fix
for this which involves removing this code and getting the right IDs from
BIOS, so we wont need this code.

Thanks
-- 
~Vinod

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]