All of lore.kernel.org
 help / color / mirror / Atom feed
From: Will Deacon <will.deacon@arm.com>
To: Hekuang <hekuang@huawei.com>
Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
	alexander.shishkin@linux.intel.com, adrian.hunter@intel.com,
	jolsa@kernel.org, linux-kernel@vger.kernel.org,
	wangnan0@huawei.com, pi3orama@163.com
Subject: Re: [BUG ARM64/perf] Perf record on hardware breakpoint causes application to hang
Date: Thu, 3 Mar 2016 15:01:25 +0000	[thread overview]
Message-ID: <20160303150125.GB16061@arm.com> (raw)
In-Reply-To: <56D83771.2090101@huawei.com>

On Thu, Mar 03, 2016 at 09:09:05PM +0800, Hekuang wrote:
> This problem can be reproduced as follows:
> 
> We know cat /proc/version will read the memory of symbol
> linux_proc_banner, then we make a hardware memory access
> breakpoint on that address.
> 
> on terminal 1:
> 
>   $ perf record -e mem:0x$(cat /proc/kallsyms|grep linux_proc_banner|cut -d
> " " -f 1):rw --no-buffer -a
> 
> on terminal 2:
> 
>   $ cat /proc/version
> 
> Then our 'cat' process on terminal 2 will be hanged, until we press
> '^C' to stop perf from recording events.
> 
> The sample numbers recorded by perf is extraordinary too:
> 
>   [ perf record: Captured and wrote 0.879 MB perf.data (22691 samples) ]
> 
> The right result can be produced by removing the 'no-buffer'
> argument in perf command line, and the result should be like
> this:
> 
>   $ perf record -e mem:0x$(cat /proc/kallsyms|grep linux_proc_
>                            banner|cut -d " " -f 1):rw  -a
>   ^C
>   [ perf record: Woken up 1 times to write data ]
>   [ perf record: Captured and wrote 0.013 MB perf.data (10 samples) ]
> 
> Report this bug to you and hope for answers.

This sounds like a kernel-space equivalent to the issue reported here:

  http://lkml.kernel.org/r/569CCEDA.6040103@huawei.com

The problem is that we configure a single-step to step the watchpoint
and then re-arm it on completion, but because you have buffering disabled,
we *always* step into an interrupt thanks to the irq work that is queued
by perf to unblock the event fd being polled. We then re-arm the watchpoint
and take it immediately on return from the irq handler. Rinse, repeat.

We could consider re-enabling interrupts briefly on the debug exception
return path, but then we open ourselves up to black spots in the kernel
that cannot be debugged.

Will

      reply	other threads:[~2016-03-03 15:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-03 13:09 [BUG ARM64/perf] Perf record on hardware breakpoint causes application to hang Hekuang
2016-03-03 15:01 ` Will Deacon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160303150125.GB16061@arm.com \
    --to=will.deacon@arm.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=hekuang@huawei.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=pi3orama@163.com \
    --cc=wangnan0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.