From mboxrd@z Thu Jan  1 00:00:00 1970
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] staging/android: add flags member to sync ioctl structs
Date: Thu, 3 Mar 2016 08:17:14 -0800
Message-ID: <20160303161714.GA4133@kroah.com>
References: <1456955489-18971-1-git-send-email-gustavo@padovan.org>
 <1457015837-7609-1-git-send-email-gustavo@padovan.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from mail.linuxfoundation.org (mail.linuxfoundation.org
 [140.211.169.12])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 1191A6E149
 for <dri-devel@lists.freedesktop.org>; Thu,  3 Mar 2016 16:17:15 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <1457015837-7609-1-git-send-email-gustavo@padovan.org>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Gustavo Padovan <gustavo@padovan.org>
Cc: devel@driverdev.osuosl.org, Daniel Stone <daniels@collabora.com>, Daniel Vetter <daniel.vetter@ffwll.ch>, Riley Andrews <riandrews@android.com>, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Arve =?iso-8859-1?B?SGr4bm5lduVn?= <arve@android.com>, Gustavo Padovan <gustavo.padovan@collabora.co.uk>, John Harrison <John.C.Harrison@Intel.com>
List-Id: dri-devel@lists.freedesktop.org

T24gVGh1LCBNYXIgMDMsIDIwMTYgYXQgMTE6Mzc6MTdBTSAtMDMwMCwgR3VzdGF2byBQYWRvdmFu
IHdyb3RlOgo+IEZyb206IEd1c3Rhdm8gUGFkb3ZhbiA8Z3VzdGF2by5wYWRvdmFuQGNvbGxhYm9y
YS5jby51az4KPiAKPiBQbGF5IHNhZmUgYW5kIGFkZCBmbGFncyBtZW1iZXIgdG8gYWxsIHN0cnVj
dHMuIFNvIHdlIGRvbid0IG5lZWQgdG8KPiBicmVhayBBUEkgb3IgY3JlYXRlIG5ldyBJT0NUTCBp
biB0aGUgZnV0dXJlIGlmIG5ldyBmZWF0dXJlcyB0aGF0IHJlcXVpcmVzCj4gZmxhZ3MgYXJpc2Vz
Lgo+IAo+IHYyOiBjaGVjayBpZiBmbGFncyBhcmUgdmFsaWQgKHplcm8sIGluIHRoaXMgY2FzZSkK
PiAKPiB2MzogcmV0dXJuIC1FSU5WQUwgaWYgZmxhZ3MgYXJlIG5vdCB6ZXJvJ2VkCj4gCj4gdjQ6
IGFkZCBwYWRkaW5nIGZvciA2NC1iaXQgYWxpZ25tZW50Cj4gCj4gdjU6IHJlYmFzZSB0byB1c2Ug
b25seSBzdGFja2VkIHN5bmNfZmlsZV9pbmZvCgpXaHkgYXJlIHRoZXNlIHZYIHRoaW5ncyBoZXJl
IGluIHRoZSBjaGFuZ2Vsb2c/CgpBbmQgeW91IGp1c3QgYnJva2UgYWxsIGV4aXN0aW5nIHVzZXJz
cGFjZSB1c2VycyBvZiB0aGlzIGNvZGUsIHdoeSBhcmUKeW91IGFsbG93ZWQgdG8gZG8gdGhhdD8K
Cm5vdCBvay4uLgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn
Cmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs
Cg==

From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757464AbcCCQRQ (ORCPT <rfc822;w@1wt.eu>);
	Thu, 3 Mar 2016 11:17:16 -0500
Received: from mail.linuxfoundation.org ([140.211.169.12]:44080 "EHLO
	mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752348AbcCCQRP (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 3 Mar 2016 11:17:15 -0500
Date: Thu, 3 Mar 2016 08:17:14 -0800
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Gustavo Padovan <gustavo@padovan.org>
Cc: devel@driverdev.osuosl.org, Rob Clark <robdclark@gmail.com>,
        Daniel Stone <daniels@collabora.com>,
        Daniel Vetter <daniel.vetter@ffwll.ch>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Riley Andrews <riandrews@android.com>, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org,
        Arve =?iso-8859-1?B?SGr4bm5lduVn?= <arve@android.com>,
        Greg Hackmann <ghackmann@google.com>,
        Gustavo Padovan <gustavo.padovan@collabora.co.uk>,
        John Harrison <John.C.Harrison@Intel.com>
Subject: Re: [PATCH] staging/android: add flags member to sync ioctl structs
Message-ID: <20160303161714.GA4133@kroah.com>
References: <1456955489-18971-1-git-send-email-gustavo@padovan.org>
 <1457015837-7609-1-git-send-email-gustavo@padovan.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1457015837-7609-1-git-send-email-gustavo@padovan.org>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Mar 03, 2016 at 11:37:17AM -0300, Gustavo Padovan wrote:
> From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> 
> Play safe and add flags member to all structs. So we don't need to
> break API or create new IOCTL in the future if new features that requires
> flags arises.
> 
> v2: check if flags are valid (zero, in this case)
> 
> v3: return -EINVAL if flags are not zero'ed
> 
> v4: add padding for 64-bit alignment
> 
> v5: rebase to use only stacked sync_file_info

Why are these vX things here in the changelog?

And you just broke all existing userspace users of this code, why are
you allowed to do that?

not ok...