From: Ido Schimmel <idosch@mellanox.com>
To: David Miller <davem@davemloft.net>
Cc: <sasha.levin@oracle.com>, <stable@vger.kernel.org>,
<stable-commits@vger.kernel.org>, <jiri@mellanox.com>
Subject: Re: [added to the 4.1 stable tree] switchdev: Require RTNL mutex to be held when sending FDB notifications
Date: Thu, 3 Mar 2016 19:52:12 +0200 [thread overview]
Message-ID: <20160303175212.GA17330@colbert.mtl.com> (raw)
In-Reply-To: <20160303.120340.1274644863637861160.davem@davemloft.net>
Thu, Mar 03, 2016 at 07:03:40PM IST, davem@davemloft.net wrote:
>From: Ido Schimmel <idosch@mellanox.com>
>Date: Thu, 3 Mar 2016 11:35:31 +0200
>
>> Hi Sasha,
>>
>> Wed, Mar 02, 2016 at 10:23:52PM IST, sasha.levin@oracle.com wrote:
>>>From: Ido Schimmel <idosch@mellanox.com>
>>>
>>>This patch has been added to the 4.1 stable tree. If you have any
>>>objections, please let us know.
>>>
>>>===============
>>>
>>>[ Upstream commit 4f2c6ae5c64c353fb1b0425e4747e5603feadba1 ]
>>>
>>>When switchdev drivers process FDB notifications from the underlying
>>>device they resolve the netdev to which the entry points to and notify
>>>the bridge using the switchdev notifier.
>>>
>>>However, since the RTNL mutex is not held there is nothing preventing
>>>the netdev from disappearing in the middle, which will cause
>>>br_switchdev_event() to dereference a non-existing netdev.
>>>
>>>Make switchdev drivers hold the lock at the beginning of the
>>>notification processing session and release it once it ends, after
>>>notifying the bridge.
>>>
>>>Also, remove switchdev_mutex and fdb_lock, as they are no longer needed
>>>when RTNL mutex is held.
>>
>> You removed the fdb_lock bits from the commit below since they aren't
>> present in kernel 4.1. Can you remove it from the description as well?
>> Should probably be:
>>
>> "Also, remove switchdev_mutex, as it's no longer needed when RTNL mutex
>> is held."
>
>No, I did this, and I do not think editing the commit log message
>contents are appropriate for stable backports ever!
OK, I wasn't aware of that. I'm good with the current patch as is in
that case.
Thank you both.
>
>You can add notes in a "[]" bracketed section, but that's it.
next prev parent reply other threads:[~2016-03-03 18:08 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-02 20:23 [added to the 4.1 stable tree] af_iucv: Validate socket address length in iucv_sock_bind() Sasha Levin
2016-03-02 20:23 ` [added to the 4.1 stable tree] net: dp83640: Fix tx timestamp overflow handling Sasha Levin
2016-03-02 20:23 ` [added to the 4.1 stable tree] tcp: fix NULL deref in tcp_v4_send_ack() Sasha Levin
2016-03-02 20:23 ` [added to the 4.1 stable tree] af_unix: fix struct pid memory leak Sasha Levin
2016-03-02 20:23 ` [added to the 4.1 stable tree] pptp: fix illegal memory access caused by multiple bind()s Sasha Levin
2016-03-02 20:23 ` [added to the 4.1 stable tree] sctp: allow setting SCTP_SACK_IMMEDIATELY by the application Sasha Levin
2016-03-02 20:23 ` [added to the 4.1 stable tree] tipc: fix connection abort during subscription cancel Sasha Levin
2016-03-02 20:23 ` [added to the 4.1 stable tree] switchdev: Require RTNL mutex to be held when sending FDB notifications Sasha Levin
2016-03-03 9:35 ` Ido Schimmel
2016-03-03 17:03 ` David Miller
2016-03-03 17:52 ` Ido Schimmel [this message]
2016-03-02 20:23 ` [added to the 4.1 stable tree] tcp: beware of alignments in tcp_get_info() Sasha Levin
2016-03-02 20:23 ` [added to the 4.1 stable tree] ipv6: enforce flowi6_oif usage in ip6_dst_lookup_tail() Sasha Levin
2016-03-02 20:23 ` [added to the 4.1 stable tree] ipv6/udp: use sticky pktinfo egress ifindex on connect() Sasha Levin
2016-03-02 20:23 ` [added to the 4.1 stable tree] net/ipv6: add sysctl option accept_ra_min_hop_limit Sasha Levin
2016-03-02 20:23 ` [added to the 4.1 stable tree] ipv6: addrconf: Fix recursive spin lock call Sasha Levin
2016-03-02 20:23 ` [added to the 4.1 stable tree] ipv6: fix a lockdep splat Sasha Levin
2016-03-02 20:23 ` [added to the 4.1 stable tree] unix: correctly track in-flight fds in sending process user_struct Sasha Levin
2016-03-02 20:24 ` [added to the 4.1 stable tree] net:Add sysctl_max_skb_frags Sasha Levin
2016-03-02 20:24 ` [added to the 4.1 stable tree] tg3: Fix for tg3 transmit queue 0 timed out when too many gso_segs Sasha Levin
2016-03-02 20:24 ` [added to the 4.1 stable tree] sctp: translate network order to host order when users get a hmacid Sasha Levin
2016-03-02 20:24 ` [added to the 4.1 stable tree] flow_dissector: Fix unaligned access in __skb_flow_dissector when used by eth_get_headlen Sasha Levin
2016-03-02 20:24 ` [added to the 4.1 stable tree] net: Copy inner L3 and L4 headers as unaligned on GRE TEB Sasha Levin
2016-03-02 20:24 ` [added to the 4.1 stable tree] bpf: fix branch offset adjustment on backjumps after patching ctx expansion Sasha Levin
2016-03-02 20:24 ` [added to the 4.1 stable tree] bonding: Fix ARP monitor validation Sasha Levin
2016-03-02 20:24 ` [added to the 4.1 stable tree] ipv4: fix memory leaks in ip_cmsg_send() callers Sasha Levin
2016-03-02 20:24 ` [added to the 4.1 stable tree] af_unix: Guard against other == sk in unix_dgram_sendmsg Sasha Levin
2016-03-02 20:24 ` [added to the 4.1 stable tree] qmi_wwan: add "4G LTE usb-modem U901" Sasha Levin
2016-03-02 20:24 ` [added to the 4.1 stable tree] net/mlx4_en: Count HW buffer overrun only once Sasha Levin
2016-03-02 20:24 ` [added to the 4.1 stable tree] net/mlx4_en: Choose time-stamping shift value according to HW frequency Sasha Levin
2016-03-02 20:24 ` [added to the 4.1 stable tree] net/mlx4_en: Avoid changing dev->features directly in run-time Sasha Levin
2016-03-02 20:24 ` [added to the 4.1 stable tree] l2tp: Fix error creating L2TP tunnels Sasha Levin
2016-03-02 20:24 ` [added to the 4.1 stable tree] pppoe: fix reference counting in PPPoE proxy Sasha Levin
2016-03-02 20:24 ` [added to the 4.1 stable tree] route: check and remove route cache when we get route Sasha Levin
2016-03-02 20:24 ` [added to the 4.1 stable tree] rtnl: RTM_GETNETCONF: fix wrong return value Sasha Levin
2016-03-02 20:24 ` [added to the 4.1 stable tree] unix_diag: fix incorrect sign extension in unix_lookup_by_ino Sasha Levin
2016-03-02 20:24 ` [added to the 4.1 stable tree] sctp: Fix port hash table size computation Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160303175212.GA17330@colbert.mtl.com \
--to=idosch@mellanox.com \
--cc=davem@davemloft.net \
--cc=jiri@mellanox.com \
--cc=sasha.levin@oracle.com \
--cc=stable-commits@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.