All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Colin King <colin.king@canonical.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@kernel.org>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>, Wang Nan <wangnan0@huawei.com>,
	He Kuang <hekuang@huawei.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf tools: explicitly declare inc_group_count as a void function
Date: Thu, 3 Mar 2016 16:59:29 -0300	[thread overview]
Message-ID: <20160303195929.GW3604@kernel.org> (raw)
In-Reply-To: <20160303123939.GA1466@krava.redhat.com>

Em Thu, Mar 03, 2016 at 01:39:39PM +0100, Jiri Olsa escreveu:
> On Thu, Mar 03, 2016 at 12:30:14PM +0000, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> > 
> > The return type is not defined, so it defaults to int, however,
> > the function is not returning anything, so this is clearly not
> > correct. Make it a void function.
> 
> Acked-by: Jiri Olsa <jolsa@kernel.org>

Thanks, applied.

  reply	other threads:[~2016-03-03 19:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-03 12:30 [PATCH] perf tools: explicitly declare inc_group_count as a void function Colin King
2016-03-03 12:39 ` Jiri Olsa
2016-03-03 19:59   ` Arnaldo Carvalho de Melo [this message]
2016-03-08 10:29 ` [tip:perf/core] perf tools: Explicitly " tip-bot for Colin Ian King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160303195929.GW3604@kernel.org \
    --to=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=colin.king@canonical.com \
    --cc=hekuang@huawei.com \
    --cc=jolsa@kernel.org \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=wangnan0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.