From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] staging/android: add flags member to sync ioctl structs Date: Thu, 3 Mar 2016 22:01:12 +0200 Message-ID: <20160303200112.GL10446@intel.com> References: <1456955489-18971-1-git-send-email-gustavo@padovan.org> <1457015837-7609-1-git-send-email-gustavo@padovan.org> <20160303161714.GA4133@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id BA1F46E021 for ; Thu, 3 Mar 2016 20:01:19 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20160303161714.GA4133@kroah.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Greg Kroah-Hartman Cc: devel@driverdev.osuosl.org, Daniel Stone , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Riley Andrews , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Daniel Vetter , Gustavo Padovan , John Harrison List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBNYXIgMDMsIDIwMTYgYXQgMDg6MTc6MTRBTSAtMDgwMCwgR3JlZyBLcm9haC1IYXJ0 bWFuIHdyb3RlOgo+IE9uIFRodSwgTWFyIDAzLCAyMDE2IGF0IDExOjM3OjE3QU0gLTAzMDAsIEd1 c3Rhdm8gUGFkb3ZhbiB3cm90ZToKPiA+IEZyb206IEd1c3Rhdm8gUGFkb3ZhbiA8Z3VzdGF2by5w YWRvdmFuQGNvbGxhYm9yYS5jby51az4KPiA+IAo+ID4gUGxheSBzYWZlIGFuZCBhZGQgZmxhZ3Mg bWVtYmVyIHRvIGFsbCBzdHJ1Y3RzLiBTbyB3ZSBkb24ndCBuZWVkIHRvCj4gPiBicmVhayBBUEkg b3IgY3JlYXRlIG5ldyBJT0NUTCBpbiB0aGUgZnV0dXJlIGlmIG5ldyBmZWF0dXJlcyB0aGF0IHJl cXVpcmVzCj4gPiBmbGFncyBhcmlzZXMuCj4gPiAKPiA+IHYyOiBjaGVjayBpZiBmbGFncyBhcmUg dmFsaWQgKHplcm8sIGluIHRoaXMgY2FzZSkKPiA+IAo+ID4gdjM6IHJldHVybiAtRUlOVkFMIGlm IGZsYWdzIGFyZSBub3QgemVybydlZAo+ID4gCj4gPiB2NDogYWRkIHBhZGRpbmcgZm9yIDY0LWJp dCBhbGlnbm1lbnQKPiA+IAo+ID4gdjU6IHJlYmFzZSB0byB1c2Ugb25seSBzdGFja2VkIHN5bmNf ZmlsZV9pbmZvCj4gCj4gV2h5IGFyZSB0aGVzZSB2WCB0aGluZ3MgaGVyZSBpbiB0aGUgY2hhbmdl bG9nPwoKVGhhdCdzIGhvdyB3ZSB1c3VhbGx5IHJvbGwgaW4gZ3B1IGxhbmQuCgotLSAKVmlsbGUg U3lyasOkbMOkCkludGVsIE9UQwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9k cmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753192AbcCCUBV (ORCPT ); Thu, 3 Mar 2016 15:01:21 -0500 Received: from mga11.intel.com ([192.55.52.93]:62989 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751228AbcCCUBV (ORCPT ); Thu, 3 Mar 2016 15:01:21 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,533,1449561600"; d="scan'208";a="926290617" Date: Thu, 3 Mar 2016 22:01:12 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Greg Kroah-Hartman Cc: Gustavo Padovan , devel@driverdev.osuosl.org, Daniel Stone , Daniel Vetter , Riley Andrews , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Gustavo Padovan , John Harrison Subject: Re: [PATCH] staging/android: add flags member to sync ioctl structs Message-ID: <20160303200112.GL10446@intel.com> References: <1456955489-18971-1-git-send-email-gustavo@padovan.org> <1457015837-7609-1-git-send-email-gustavo@padovan.org> <20160303161714.GA4133@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160303161714.GA4133@kroah.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 03, 2016 at 08:17:14AM -0800, Greg Kroah-Hartman wrote: > On Thu, Mar 03, 2016 at 11:37:17AM -0300, Gustavo Padovan wrote: > > From: Gustavo Padovan > > > > Play safe and add flags member to all structs. So we don't need to > > break API or create new IOCTL in the future if new features that requires > > flags arises. > > > > v2: check if flags are valid (zero, in this case) > > > > v3: return -EINVAL if flags are not zero'ed > > > > v4: add padding for 64-bit alignment > > > > v5: rebase to use only stacked sync_file_info > > Why are these vX things here in the changelog? That's how we usually roll in gpu land. -- Ville Syrjälä Intel OTC