From: Wolfram Sang <wsa@the-dreams.de>
To: Dmitriy Baranov <dbaranov@dev.rtsoft.ru>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
Maxim Syrchin <syrchin@dev.rtsoft.ru>
Subject: Re: [PATCH] i2c: imx: add slave support. v2
Date: Thu, 3 Mar 2016 22:35:10 +0100 [thread overview]
Message-ID: <20160303213509.GF1501@katana> (raw)
In-Reply-To: <1453824880-4844-1-git-send-email-dbaranov@dev.rtsoft.ru>
[-- Attachment #1: Type: text/plain, Size: 649 bytes --]
On Tue, Jan 26, 2016 at 07:14:40PM +0300, Dmitriy Baranov wrote:
> Add I2C slave provider using the generic slave interface.
> It also supports master transactions when the slave in the idle mode.
>
> Issues:
> Changes work only in PIO mode (when driver doesn`t use DMA)
This is fine with me. We don't support block transfers currently in the
slave core anyhow.
> There are might be race conditions.
Can you name them
> +enum imx_i2c_slave_state {
> + I2C_IMX_SLAVE_IDLE,
> + I2C_IMX_SLAVE_IRQ,
> + I2C_IMX_SLAVE_POLLING
Highlevel question first: Why do you have polling? Why would anyone not
want to use interrupts here?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-03-03 21:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-26 16:14 [PATCH] i2c: imx: add slave support. v2 Dmitriy Baranov
2016-03-03 21:35 ` Wolfram Sang [this message]
2016-03-04 11:06 ` Maxim Syrchin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160303213509.GF1501@katana \
--to=wsa@the-dreams.de \
--cc=dbaranov@dev.rtsoft.ru \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=syrchin@dev.rtsoft.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.