From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pratyush Anand Subject: Re: [PATCH V2 dracut 0/2] Install kernel module for active watchdog Date: Fri, 4 Mar 2016 09:04:43 +0530 Message-ID: <20160304033443.GB7467@dhcppc3.redhat.com> References: <20160304031633.GB3592@dhcp-128-65.nay.redhat.com> Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: <20160304031633.GB3592-0VdLhd/A9Pl+NNSt+8eSiB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org> Sender: initramfs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dave Young Cc: initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dzickus-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org Hi Dave, On 04/03/2016:11:16:33 AM, Dave Young wrote: > Hi, Pratyush > > On 03/02/16 at 05:36pm, Pratyush Anand wrote: > > Changes since RFC: > > -- Added one more patch to take care that dracut does not add watchdog > > hooks when systemd module is included. In that case systemd daemon will > > manage watchdog for kicking. > > -- Removed --nowdt argument. User can use -o or --omit when wathdog module > > is not needed. Thanks Harald for this suggestion. > > -- Now I also do not check for "hostonly" to add modules for active > > watchdog. It seems reasonable to add kernel watchdog modules whenever, > > dracut watchdog module has been added. > > >From my understanding hostonly is a different mode comparing with the default > one which being used for distribution provided initramfs. In the latter case > all possible drivers should be included. But hostonly mode only adding the > drivers being used in this boot. From the code logic we provided it will detect > active wdt module and add the driver, the behavior is just "hostonly", no? I think, I am agreeing to this. So, should we also add no "hostonly" case where driver will be present irrespective of whether wdt is active or not? May be we can leave it for now, and can be added if someone needs it latter. ~Pratyush