From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Jones <drjones@redhat.com>
Subject: Re: [kvm-unit-tests] powerpc: fix boot_rom.bin build
Date: Fri, 4 Mar 2016 11:31:53 +0100
Message-ID: <20160304103152.GA3304@localhost.redhat.com>
References: <1457038529-4577-1-git-send-email-pfeiner@google.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: kvm@vger.kernel.org, pbonzini@redhat.com
To: Peter Feiner <pfeiner@google.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:41097 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752112AbcCDKcA (ORCPT <rfc822;kvm@vger.kernel.org>);
	Fri, 4 Mar 2016 05:32:00 -0500
Content-Disposition: inline
In-Reply-To: <1457038529-4577-1-git-send-email-pfeiner@google.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Thu, Mar 03, 2016 at 12:55:29PM -0800, Peter Feiner wrote:
> My powerpc objcopy (version 2.23.52.20130305) did a seek() that
> bash process substitution couldn't handle! I've changed the
> Makefile to do things the old fashioned way.
> 
> Signed-off-by: Peter Feiner <pfeiner@google.com>
> ---
>  powerpc/Makefile.common | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/powerpc/Makefile.common b/powerpc/Makefile.common
> index 424983e..7818c48 100644
> --- a/powerpc/Makefile.common
> +++ b/powerpc/Makefile.common
> @@ -48,7 +48,8 @@ FLATLIBS = $(libcflat) $(LIBFDT_archive)
>  
>  $(TEST_DIR)/boot_rom.bin: $(TEST_DIR)/boot_rom.elf
>  	dd if=/dev/zero of=$@ bs=256 count=1
> -	$(OBJCOPY) -O binary $^ >(cat - >>$@)
> +	$(OBJCOPY) -O binary $^ $@.suffix
> +	cat $@.suffix >> $@
>  
>  $(TEST_DIR)/boot_rom.elf: CFLAGS = -mbig-endian
>  $(TEST_DIR)/boot_rom.elf: $(TEST_DIR)/boot_rom.o
> -- 
> 2.7.0.rc3.207.g0ac5344

Reviewed-by: Andrew Jones <drjones@redhat.com>