From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Jiri Olsa <jolsa@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
David Ahern <dsahern@gmail.com>, Andi Kleen <andi@firstfloor.org>,
Stephane Eranian <eranian@google.com>,
Wang Nan <wangnan0@huawei.com>
Subject: Re: [RFC] Re: [PATCHSET 0/8] perf tools: Support multiple keys in a single hierarchy level (v1)
Date: Fri, 4 Mar 2016 10:32:19 -0300 [thread overview]
Message-ID: <20160304133219.GX3604@kernel.org> (raw)
In-Reply-To: <20160303235051.GA16631@sejong>
Em Fri, Mar 04, 2016 at 08:50:51AM +0900, Namhyung Kim escreveu:
> On Thu, Mar 03, 2016 at 10:08:15AM -0300, Arnaldo Carvalho de Melo wrote:
> > We should try to use tokens that already have some strong meaning
> > associated to them instead of using those that are more easily
> > available, otherwise our mumbo jumbo will grow even more unwieldly 8-/
> > In fact I think that in this case we could even make it look more like
> > natural languages and use:
> > perf report --hierarchy -s 'prev_pid,prev_comm;next_pid,next_comm'
> > To ask for:
> > prev_pid prev_comm
> > next_pid next_comm
> > - 1234 bash
> > 5678 firefox
> > + 8912 hexchat
> > I.e. if ';' is present, it is the separator for each hierarchy level,
> > with ',' being used for stating the per-hierarchy level fields.
> If it's not a common operation and we have used '{ }' for the event
> groups, why not using it here too?
> $ perf report --hierarchy -s '{prev_pid,prev_comm},{next_pid,next_comm}'
> It's more verbose but more intuitive IMHO.
Right, we would be using {} consistently as a way of grouping entities.
I'm fine with that.
- Arnaldo
prev parent reply other threads:[~2016-03-04 13:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-02 16:12 [PATCHSET 0/8] perf tools: Support multiple keys in a single hierarchy level (v1) Namhyung Kim
2016-03-02 16:12 ` [PATCH 1/8] perf tools: Add level field to struct perf_hpp_fmt Namhyung Kim
2016-03-02 16:12 ` [PATCH 2/8] perf tools: Introduce perf_hpp__setup_hists_formats() Namhyung Kim
2016-03-03 13:40 ` Jiri Olsa
2016-03-03 23:52 ` Namhyung Kim
2016-03-03 13:40 ` Jiri Olsa
2016-03-03 23:53 ` Namhyung Kim
2016-03-02 16:12 ` [PATCH 3/8] perf tools: Use own hpp_list for hierarchy mode Namhyung Kim
2016-03-02 16:12 ` [PATCH 4/8] perf tools: Support multiple sort keys in a hierarchy Namhyung Kim
2016-03-02 16:12 ` [PATCH 5/8] perf tools: Fix indent for multiple hierarchy sort key Namhyung Kim
2016-03-02 16:12 ` [PATCH 6/8] perf report: Use hierarchy hpp list on stdio Namhyung Kim
2016-03-02 16:12 ` [PATCH 7/8] perf hists browser: Use hierarchy hpp list Namhyung Kim
2016-03-02 16:12 ` [PATCH 8/8] perf report: Use hierarchy hpp list on gtk Namhyung Kim
2016-03-02 16:25 ` [PATCHSET 0/8] perf tools: Support multiple keys in a single hierarchy level (v1) Arnaldo Carvalho de Melo
2016-03-02 23:16 ` Namhyung Kim
2016-03-03 13:08 ` [RFC] " Arnaldo Carvalho de Melo
2016-03-03 23:50 ` Namhyung Kim
2016-03-04 13:32 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160304133219.GX3604@kernel.org \
--to=acme@kernel.org \
--cc=andi@firstfloor.org \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.