All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemming@brocade.com>
To: Phil Sutter <phil@nwl.cc>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [iproute PATCH] libnetlink: Double the dump buffer size
Date: Fri, 4 Mar 2016 15:35:53 -0800	[thread overview]
Message-ID: <20160304153553.47e8741d@xeon-e3> (raw)
In-Reply-To: <8e235f49b8314d70bbf76709a81c4d84@HQ1WP-EXMB11.corp.brocade.com>

On Fri, 4 Mar 2016 18:57:28 +0000
Phil Sutter <phil@nwl.cc> wrote:

> There have been reports about 'ip addr' printing "Message truncated" on
> systems with large numbers of VFs. Although I haven't been able to get
> my hands on hardware suitable to reproduce this, increasing the dump
> buffer has been reported to resolve the issue. For want of a better
> idea, just double the buffer size to 32k.
> 
> Feels like this opportunistic buffer size selection is rather
> workarounding a design flaw in libnetlink or maybe even the netlink
> protocol itself.
> 
> Signed-off-by: Phil Sutter <phil@nwl.cc>
> ---
>  lib/libnetlink.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/libnetlink.c b/lib/libnetlink.c
> index d6b5fd3e8a493..245c4ca216753 100644
> --- a/lib/libnetlink.c
> +++ b/lib/libnetlink.c
> @@ -223,7 +223,7 @@ int rtnl_dump_filter_l(struct rtnl_handle *rth,
>  		.msg_iov = &iov,
>  		.msg_iovlen = 1,
>  	};
> -	char buf[16384];
> +	char buf[32768];
>  	int dump_intr = 0;
>  
>  	iov.iov_base = buf;

I thought this was addressed in kernel by making the VF info optional.
The netlink protocol is showing some strain, this is one of them.

       reply	other threads:[~2016-03-04 23:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <8e235f49b8314d70bbf76709a81c4d84@HQ1WP-EXMB11.corp.brocade.com>
2016-03-04 23:35 ` Stephen Hemminger [this message]
2016-03-05  0:57   ` [iproute PATCH] libnetlink: Double the dump buffer size Phil Sutter
2016-03-05 21:12   ` Johannes Berg
     [not found]   ` <20160305005746.GS28939@base.sg13b.nwl.cc>
2016-03-08 13:28     ` Phil Sutter
2016-03-04 18:57 Phil Sutter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160304153553.47e8741d@xeon-e3 \
    --to=shemming@brocade.com \
    --cc=netdev@vger.kernel.org \
    --cc=phil@nwl.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.