Re: [PATCH v4 03/10] tpm: Provide strong locking for device removal

[Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>]

On Mon, Feb 29, 2016 at 03:04:10PM -0500, Stefan Berger wrote:
>    Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> wrote on 02/29/2016
>    02:54:01 PM:
> 
>    >
>    > On Mon, Feb 29, 2016 at 02:48:54PM -0500, Stefan Berger wrote:
>    > >    Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> wrote on
>    02/29/2016
>    > >    02:25:32 PM:
>    > >    >
>    > >    > On Mon, Feb 29, 2016 at 12:29:49PM -0500, Stefan Berger wrote:
>    > >    > >   * the device. As the last step this function adds the chip to
>    > >    > the list of TPM
>    > >    > >   * chips available for in-kernel use.
>    > >    > >   *
>    > >    > > + * Once this function returns the driver call backs in 'op's
>    will
>    > >    not be
>    > >    > > + * running and will no longer start.
>    > >    > > + *
>    > >    > >   * This function should be only called after the chip
>    > >    initialization is
>    > >    > >   * complete.
>    > >    > >   */
>    > >    >
>    > >    > Not sure what happened here, but this hunk belongs with
>    > >    > tpm_chip_unregister
>    > >    That's where it is. The context 'tpm1_chip_unregister' the hunk
>    shows
>    > >    is from the function 'above'.
>    >
>    > Eh?
>    >
>    > https://github.com/stefanberger/linux/blob/
>    >
>    63f0cd1bae930167d31bbe5d5779d40a277e91c5/drivers/char/tpm/tpm-chip.c#L311
> 
>    Sorry. Fixed here :
>    https://github.com/stefanberger/linux/commit/5808cd0b01b00e1a4e3b23d6970bac4efee69038

Already applied v4. Could you send a fix for this to the list?
Thanks.

>       Stefan

/Jarkko

------------------------------------------------------------------------------