From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760685AbcCEL0K (ORCPT ); Sat, 5 Mar 2016 06:26:10 -0500 Received: from mail-wm0-f66.google.com ([74.125.82.66]:34362 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760173AbcCEL0D (ORCPT ); Sat, 5 Mar 2016 06:26:03 -0500 Date: Sat, 5 Mar 2016 12:25:57 +0100 From: Ingo Molnar To: Tetsuo Handa Cc: kuleshovmail@gmail.com, bp@suse.de, akpm@linux-foundation.org, bhe@redhat.com, dyoung@redhat.com, jroedel@suse.de, torvalds@linux-foundation.org, msalter@redhat.com, peterz@infradead.org, tglx@linutronix.de, linux-kernel@vger.kernel.org Subject: Re: [linux-next-20160302] Can't unpack initramfs. Message-ID: <20160305112557.GC23473@gmail.com> References: <201603031951.GEB17681.FSFHOQOOMJLFtV@I-love.SAKURA.ne.jp> <201603051759.IFI12853.tFVHQLJOSFMOOF@I-love.SAKURA.ne.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201603051759.IFI12853.tFVHQLJOSFMOOF@I-love.SAKURA.ne.jp> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Tetsuo Handa wrote: > I'm hitting a problem that initramfs is corrupted when booting from GRUB2 on VMware Player 6.0.6. > This problem does not occur when booting from qemu-kvm or from PXE on VMware Player 6.0.6. > Bisection reached to "x86/setup: Calculate ramdisk parameters only once". that commit is crap, as it changed the size calculation: - u64 ramdisk_size = get_ramdisk_size(); - ramdisk_size); + ramdisk->size); + struct ramdisk ramdisk = { + .start_addr = get_ramdisk_image(), + .size = PAGE_ALIGN(get_ramdisk_size()), + .reserve_ramdisk = true + }; I've zapped it. Thanks, Ingo