From: Greg KH <gregkh@linuxfoundation.org>
To: Sandhya Bankar <bankarsandhya512@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH] Staging: lustre: wiretest: Remove int typecast of offsetof().
Date: Sat, 5 Mar 2016 11:56:16 -0800 [thread overview]
Message-ID: <20160305195616.GA15835@kroah.com> (raw)
In-Reply-To: <20160303105513.GA5491@sandhya>
On Thu, Mar 03, 2016 at 04:25:13PM +0530, Sandhya Bankar wrote:
> Remove int typecast of offsetof().
> As per below coccinelle rule:
>
> @@
> type T;
> expression E;
> @@
>
> - (int)(offsetof(T,E))
> + offsetof(T,E)
>
> Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
> ---
> drivers/staging/lustre/lustre/ptlrpc/wiretest.c | 2842 +++++++++++------------
> 1 file changed, 1421 insertions(+), 1421 deletions(-)
You didn't even test-build this patch, please NEVER do that as it breaks
the development workflow of a maintainer and makes them really grumpy :(
greg k-h
prev parent reply other threads:[~2016-03-05 19:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-03 10:55 [PATCH] Staging: lustre: wiretest: Remove int typecast of offsetof() Sandhya Bankar
2016-03-05 19:56 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160305195616.GA15835@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bankarsandhya512@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.