From: Theodore Ts'o <tytso@mit.edu>
To: Li Xi <pkuelelixi@gmail.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [v4 1/6] Always read full inode structure
Date: Sun, 6 Mar 2016 00:46:22 -0500 [thread overview]
Message-ID: <20160306054622.GK10297@thunk.org> (raw)
In-Reply-To: <1457237696-13770-2-git-send-email-lixi@ddn.com>
On Sun, Mar 06, 2016 at 01:14:51PM +0900, Li Xi wrote:
> Project quota need use some extra field of inode for computing quota
> accounting, this patch tries to use ext2fs_get_next_inode_full()
> everywhere to read full inode into memeory.
>
> It also fixes a bug that only copy small inode in the function.
>
> Signed-off-by: Wang Shilong <wshilong@ddn.com>
Um, no. Most of the places where we are currently using
ext2fs_get_next_inode() is because they **don't** need the full inode.
For example, consider debugfs's icheck command. Why would it need the
project quota id? Answer: it doesn't.
If you think there is a bug, or some place where we should be using
the large inode, fine. Let's take a look at it. But doing a whole
sale conversion of ext2fs_get_next_inode() to
ext2fs_get_next_inode_full() makes e2fsprogs much less efficient, and
for no good purpose.
- Ted
next prev parent reply other threads:[~2016-03-06 5:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-06 4:14 [v4 0/6] Add project quota support for e2fsprogs Li Xi
2016-03-06 4:14 ` [v4 1/6] Always read full inode structure Li Xi
2016-03-06 5:46 ` Theodore Ts'o [this message]
2016-03-06 6:27 ` Andreas Dilger
2016-03-06 19:31 ` Theodore Ts'o
2016-03-06 4:14 ` [v4 2/6] Clean up codes for adding new quota type Li Xi
2016-03-06 4:14 ` [v4 3/6] Add project feature flag EXT4_FEATURE_RO_COMPAT_PROJECT Li Xi
2016-03-06 4:14 ` [v4 4/6] Add project quota support Li Xi
2016-03-06 4:14 ` [v4 5/6] Add inherit flags for project quota Li Xi
2016-03-06 4:14 ` [v4 6/6] Add project ID support for chattr/lsattr Li Xi
2016-03-06 5:56 ` Theodore Ts'o
2016-03-06 10:49 ` Li Xi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160306054622.GK10297@thunk.org \
--to=tytso@mit.edu \
--cc=linux-ext4@vger.kernel.org \
--cc=pkuelelixi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.