From: Sandhya Bankar <bankarsandhya512@gmail.com>
To: outreachy-kernel@googlegroups.com
Subject: [PATCH v2] Staging: lustre: api-ni: Remove int typecast of offsetof().
Date: Sun, 6 Mar 2016 12:04:44 +0530 [thread overview]
Message-ID: <20160306063444.GA29852@sandhya> (raw)
Remove int typecast of offsetof().
As per below coccinelle rule:
@@
type T;
expression E;
@@
- (int)(offsetof(T,E))
+ offsetof(T,E)
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
---
changes in v2
*Fix compilation warnings.
drivers/staging/lustre/lnet/lnet/api-ni.c | 64 +++++++++++++++----------------
1 file changed, 32 insertions(+), 32 deletions(-)
diff --git a/drivers/staging/lustre/lnet/lnet/api-ni.c b/drivers/staging/lustre/lnet/lnet/api-ni.c
index 99cdf9e..19d56d3 100644
--- a/drivers/staging/lustre/lnet/lnet/api-ni.c
+++ b/drivers/staging/lustre/lnet/lnet/api-ni.c
@@ -195,77 +195,77 @@ static void lnet_assert_wire_constants(void)
/* Checks for struct ptl_handle_wire_t */
CLASSERT((int)sizeof(lnet_handle_wire_t) == 16);
- CLASSERT((int)offsetof(lnet_handle_wire_t, wh_interface_cookie) == 0);
+ CLASSERT(offsetof(lnet_handle_wire_t, wh_interface_cookie) == 0);
CLASSERT((int)sizeof(((lnet_handle_wire_t *)0)->wh_interface_cookie) == 8);
- CLASSERT((int)offsetof(lnet_handle_wire_t, wh_object_cookie) == 8);
+ CLASSERT(offsetof(lnet_handle_wire_t, wh_object_cookie) == 8);
CLASSERT((int)sizeof(((lnet_handle_wire_t *)0)->wh_object_cookie) == 8);
/* Checks for struct lnet_magicversion_t */
CLASSERT((int)sizeof(lnet_magicversion_t) == 8);
- CLASSERT((int)offsetof(lnet_magicversion_t, magic) == 0);
+ CLASSERT(offsetof(lnet_magicversion_t, magic) == 0);
CLASSERT((int)sizeof(((lnet_magicversion_t *)0)->magic) == 4);
- CLASSERT((int)offsetof(lnet_magicversion_t, version_major) == 4);
+ CLASSERT(offsetof(lnet_magicversion_t, version_major) == 4);
CLASSERT((int)sizeof(((lnet_magicversion_t *)0)->version_major) == 2);
- CLASSERT((int)offsetof(lnet_magicversion_t, version_minor) == 6);
+ CLASSERT(offsetof(lnet_magicversion_t, version_minor) == 6);
CLASSERT((int)sizeof(((lnet_magicversion_t *)0)->version_minor) == 2);
/* Checks for struct lnet_hdr_t */
CLASSERT((int)sizeof(lnet_hdr_t) == 72);
- CLASSERT((int)offsetof(lnet_hdr_t, dest_nid) == 0);
+ CLASSERT(offsetof(lnet_hdr_t, dest_nid) == 0);
CLASSERT((int)sizeof(((lnet_hdr_t *)0)->dest_nid) == 8);
- CLASSERT((int)offsetof(lnet_hdr_t, src_nid) == 8);
+ CLASSERT(offsetof(lnet_hdr_t, src_nid) == 8);
CLASSERT((int)sizeof(((lnet_hdr_t *)0)->src_nid) == 8);
- CLASSERT((int)offsetof(lnet_hdr_t, dest_pid) == 16);
+ CLASSERT(offsetof(lnet_hdr_t, dest_pid) == 16);
CLASSERT((int)sizeof(((lnet_hdr_t *)0)->dest_pid) == 4);
- CLASSERT((int)offsetof(lnet_hdr_t, src_pid) == 20);
+ CLASSERT(offsetof(lnet_hdr_t, src_pid) == 20);
CLASSERT((int)sizeof(((lnet_hdr_t *)0)->src_pid) == 4);
- CLASSERT((int)offsetof(lnet_hdr_t, type) == 24);
+ CLASSERT(offsetof(lnet_hdr_t, type) == 24);
CLASSERT((int)sizeof(((lnet_hdr_t *)0)->type) == 4);
- CLASSERT((int)offsetof(lnet_hdr_t, payload_length) == 28);
+ CLASSERT(offsetof(lnet_hdr_t, payload_length) == 28);
CLASSERT((int)sizeof(((lnet_hdr_t *)0)->payload_length) == 4);
- CLASSERT((int)offsetof(lnet_hdr_t, msg) == 32);
+ CLASSERT(offsetof(lnet_hdr_t, msg) == 32);
CLASSERT((int)sizeof(((lnet_hdr_t *)0)->msg) == 40);
/* Ack */
- CLASSERT((int)offsetof(lnet_hdr_t, msg.ack.dst_wmd) == 32);
+ CLASSERT(offsetof(lnet_hdr_t, msg.ack.dst_wmd) == 32);
CLASSERT((int)sizeof(((lnet_hdr_t *)0)->msg.ack.dst_wmd) == 16);
- CLASSERT((int)offsetof(lnet_hdr_t, msg.ack.match_bits) == 48);
+ CLASSERT(offsetof(lnet_hdr_t, msg.ack.match_bits) == 48);
CLASSERT((int)sizeof(((lnet_hdr_t *)0)->msg.ack.match_bits) == 8);
- CLASSERT((int)offsetof(lnet_hdr_t, msg.ack.mlength) == 56);
+ CLASSERT(offsetof(lnet_hdr_t, msg.ack.mlength) == 56);
CLASSERT((int)sizeof(((lnet_hdr_t *)0)->msg.ack.mlength) == 4);
/* Put */
- CLASSERT((int)offsetof(lnet_hdr_t, msg.put.ack_wmd) == 32);
+ CLASSERT(offsetof(lnet_hdr_t, msg.put.ack_wmd) == 32);
CLASSERT((int)sizeof(((lnet_hdr_t *)0)->msg.put.ack_wmd) == 16);
- CLASSERT((int)offsetof(lnet_hdr_t, msg.put.match_bits) == 48);
+ CLASSERT(offsetof(lnet_hdr_t, msg.put.match_bits) == 48);
CLASSERT((int)sizeof(((lnet_hdr_t *)0)->msg.put.match_bits) == 8);
- CLASSERT((int)offsetof(lnet_hdr_t, msg.put.hdr_data) == 56);
+ CLASSERT(offsetof(lnet_hdr_t, msg.put.hdr_data) == 56);
CLASSERT((int)sizeof(((lnet_hdr_t *)0)->msg.put.hdr_data) == 8);
- CLASSERT((int)offsetof(lnet_hdr_t, msg.put.ptl_index) == 64);
+ CLASSERT(offsetof(lnet_hdr_t, msg.put.ptl_index) == 64);
CLASSERT((int)sizeof(((lnet_hdr_t *)0)->msg.put.ptl_index) == 4);
- CLASSERT((int)offsetof(lnet_hdr_t, msg.put.offset) == 68);
+ CLASSERT(offsetof(lnet_hdr_t, msg.put.offset) == 68);
CLASSERT((int)sizeof(((lnet_hdr_t *)0)->msg.put.offset) == 4);
/* Get */
- CLASSERT((int)offsetof(lnet_hdr_t, msg.get.return_wmd) == 32);
+ CLASSERT(offsetof(lnet_hdr_t, msg.get.return_wmd) == 32);
CLASSERT((int)sizeof(((lnet_hdr_t *)0)->msg.get.return_wmd) == 16);
- CLASSERT((int)offsetof(lnet_hdr_t, msg.get.match_bits) == 48);
+ CLASSERT(offsetof(lnet_hdr_t, msg.get.match_bits) == 48);
CLASSERT((int)sizeof(((lnet_hdr_t *)0)->msg.get.match_bits) == 8);
- CLASSERT((int)offsetof(lnet_hdr_t, msg.get.ptl_index) == 56);
+ CLASSERT(offsetof(lnet_hdr_t, msg.get.ptl_index) == 56);
CLASSERT((int)sizeof(((lnet_hdr_t *)0)->msg.get.ptl_index) == 4);
- CLASSERT((int)offsetof(lnet_hdr_t, msg.get.src_offset) == 60);
+ CLASSERT(offsetof(lnet_hdr_t, msg.get.src_offset) == 60);
CLASSERT((int)sizeof(((lnet_hdr_t *)0)->msg.get.src_offset) == 4);
- CLASSERT((int)offsetof(lnet_hdr_t, msg.get.sink_length) == 64);
+ CLASSERT(offsetof(lnet_hdr_t, msg.get.sink_length) == 64);
CLASSERT((int)sizeof(((lnet_hdr_t *)0)->msg.get.sink_length) == 4);
/* Reply */
- CLASSERT((int)offsetof(lnet_hdr_t, msg.reply.dst_wmd) == 32);
+ CLASSERT(offsetof(lnet_hdr_t, msg.reply.dst_wmd) == 32);
CLASSERT((int)sizeof(((lnet_hdr_t *)0)->msg.reply.dst_wmd) == 16);
/* Hello */
- CLASSERT((int)offsetof(lnet_hdr_t, msg.hello.incarnation) == 32);
+ CLASSERT(offsetof(lnet_hdr_t, msg.hello.incarnation) == 32);
CLASSERT((int)sizeof(((lnet_hdr_t *)0)->msg.hello.incarnation) == 8);
- CLASSERT((int)offsetof(lnet_hdr_t, msg.hello.type) == 40);
+ CLASSERT(offsetof(lnet_hdr_t, msg.hello.type) == 40);
CLASSERT((int)sizeof(((lnet_hdr_t *)0)->msg.hello.type) == 4);
}
@@ -2266,8 +2266,8 @@ static int lnet_ping(lnet_process_id_t id, int timeout_ms,
}
if (nob < offsetof(lnet_ping_info_t, pi_ni[0])) {
- CERROR("%s: Short reply %d(%d min)\n", libcfs_id2str(id),
- nob, (int)offsetof(lnet_ping_info_t, pi_ni[0]));
+ CERROR("%s: Short reply %d(%ld min)\n", libcfs_id2str(id),
+ nob, offsetof(lnet_ping_info_t, pi_ni[0]));
goto out_1;
}
@@ -2275,8 +2275,8 @@ static int lnet_ping(lnet_process_id_t id, int timeout_ms,
n_ids = info->pi_nnis;
if (nob < offsetof(lnet_ping_info_t, pi_ni[n_ids])) {
- CERROR("%s: Short reply %d(%d expected)\n", libcfs_id2str(id),
- nob, (int)offsetof(lnet_ping_info_t, pi_ni[n_ids]));
+ CERROR("%s: Short reply %d(%ld expected)\n", libcfs_id2str(id),
+ nob, offsetof(lnet_ping_info_t, pi_ni[n_ids]));
goto out_1;
}
--
1.8.3.4
reply other threads:[~2016-03-06 14:34 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160306063444.GA29852@sandhya \
--to=bankarsandhya512@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.