From: Theodore Ts'o <tytso@mit.edu>
To: Andreas Dilger <adilger@dilger.ca>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH 4/6] lsattr: treat inode generation as an unsigned int
Date: Sun, 6 Mar 2016 18:13:49 -0500 [thread overview]
Message-ID: <20160306231349.GD30238@thunk.org> (raw)
In-Reply-To: <1457224716-72388-4-git-send-email-adilger@dilger.ca>
On Sat, Mar 05, 2016 at 05:38:34PM -0700, Andreas Dilger wrote:
> The EXT2_GETVERSION ioctl is defined to take a "long" parameter, but
> fgetversion() calls ioctl() with an "int" parameter instead. This is
> handled in the kernel correctly, but the generation is sign-extended
> in fgetversion() before return on 64-bit systems and lsattr prints
> it as a huge positive number for inode generation above 0x80000000:
>
> 1635574212 -------------e-- /mnt/ost0/O/0/d0/12928
> 18446744073045131735 -------------e-- /mnt/ost0/O/0/d0/166240
> 782808861 -------------e-- /mnt/ost0/O/0/d0/31744
> 18446744072181134840 -------------e-- /mnt/ost0/O/0/d0/135008
>
> Correctly assign the returned generation number as an unsigned value,
> and print it with a 10-character field width. The version is printed
> left-aligned for consistency with the old code and to ensure it is
> always printed in the first column for use with tools like "cut":
>
> 1635574212 -------------e-- /mnt/ost0/O/0/d0/12928
> 3630547415 -------------e-- /mnt/ost0/O/0/d0/166240
> 782808861 -------------e-- /mnt/ost0/O/0/d0/31744
> 2766550520 -------------e-- /mnt/ost0/O/0/d0/135008
>
> Do not return a random value from the stack as the version on error.
> Clean up some style issues and consolidate some duplicate code.
>
> Signed-off-by: Andreas Dilger <adilger@dilger.ca>
Thanks, applied.
- Ted
next prev parent reply other threads:[~2016-03-06 23:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-06 0:38 [PATCH 1/6] blkid: fix ZFS device detection Andreas Dilger
2016-03-06 0:38 ` [PATCH 2/6] debugfs: improve dump_mmp handling Andreas Dilger
2016-03-06 23:11 ` Theodore Ts'o
2016-03-06 0:38 ` [PATCH 3/6] misc: add missing declarations on maint Andreas Dilger
2016-03-06 23:12 ` Theodore Ts'o
2016-03-06 0:38 ` [PATCH 4/6] lsattr: treat inode generation as an unsigned int Andreas Dilger
2016-03-06 23:13 ` Theodore Ts'o [this message]
2016-03-06 0:38 ` [PATCH 5/6] findsuper: improve output if s_mkfs_time unset Andreas Dilger
2016-03-06 23:16 ` Theodore Ts'o
2016-03-06 0:38 ` [PATCH 6/6] debugfs: update to handle newer inode fields Andreas Dilger
2016-03-07 0:54 ` Theodore Ts'o
2016-03-06 23:10 ` [PATCH 1/6] blkid: fix ZFS device detection Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160306231349.GD30238@thunk.org \
--to=tytso@mit.edu \
--cc=adilger@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.