All of lore.kernel.org
 help / color / mirror / Atom feed
From: Theodore Ts'o <tytso@mit.edu>
To: Eric Sandeen <sandeen@redhat.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH V3] resize2fs: clear uninit BG if allocating from new group
Date: Sun, 6 Mar 2016 21:51:52 -0500	[thread overview]
Message-ID: <20160307025152.GG30238@thunk.org> (raw)
In-Reply-To: <5697F69E.4090404@redhat.com>

On Thu, Jan 14, 2016 at 01:27:26PM -0600, Eric Sandeen wrote:
> If resize2fs_get_alloc_block() allocates from a BLOCK_UNINIT
> group, nothing clears the UNINIT flag, so it is skipped when we
> go to write out modified bitmaps.  This leads to post-resize2fs
> e2fsck errors; used blocks in UNINIT groups, not marked in the
> block bitmap.  This was seen on r_ext4_small_bg.
> 
> This patch uses clear_block_uninit() to clear the flag,
> and my problem goes away.
> 
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>

Thanks, applied.  Apologies for the delay.

							- Ted

      parent reply	other threads:[~2016-03-07  2:51 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-17 22:42 [PATCH] resize2fs: clear uninit BG if allocating from new group Eric Sandeen
2015-09-17 23:55 ` Darrick J. Wong
2015-09-18  0:54   ` Eric Sandeen
2015-09-18  3:19     ` Eric Sandeen
2016-01-14 14:09 ` Eric Sandeen
2016-01-14 17:20   ` Andreas Dilger
2016-01-14 18:46 ` [PATCH V2] " Eric Sandeen
2016-01-14 18:50   ` Darrick J. Wong
2016-01-14 19:26     ` Eric Sandeen
2016-01-14 19:27   ` [PATCH V3] " Eric Sandeen
2016-01-14 19:38     ` Darrick J. Wong
2016-01-14 19:39     ` Andreas Dilger
2016-01-14 19:57     ` Eric Sandeen
2016-02-19 22:21     ` Eric Sandeen
2016-03-07  2:51     ` Theodore Ts'o [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160307025152.GG30238@thunk.org \
    --to=tytso@mit.edu \
    --cc=linux-ext4@vger.kernel.org \
    --cc=sandeen@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.