From: Theodore Ts'o <tytso@mit.edu>
To: Andreas Dilger <adilger@dilger.ca>
Cc: linux-ext4@vger.kernel.org, David Turner <novalis@novalis.org>
Subject: Re: [PATCH] e2fsck: Correct ext4 dates generated by old kernels
Date: Sun, 6 Mar 2016 22:43:31 -0500 [thread overview]
Message-ID: <20160307034331.GI30238@thunk.org> (raw)
In-Reply-To: <1455825476-36773-1-git-send-email-adilger@dilger.ca>
On Thu, Feb 18, 2016 at 12:57:56PM -0700, Andreas Dilger wrote:
> From: David Turner <novalis@novalis.org>
>
> Older kernels on 64-bit machines would incorrectly encode pre-1970
> ext4 dates as post-2311 dates. Detect and correct this (assuming the
> current date is before 2242).
>
> Includes tests for this, as well as changes to debugfs to correctly
> set crtimes.
>
> Signed-off-by: David Turner <novalis@novalis.org>
>
> - ext2_fs.h: declare EXT4_EPOCH_BITS/EXT4_EPOCH_MASK like the kernel
> instead of in a separate header in an unusual location
> - problem.h: move PR_1_EA_TIME_OUT_OF_RANGE to avoid master conflict
> - problem.c: fix PR_1_EA_TIME_OUT_OF_RANGE PR_*_OK flag usage
> - f_pre_1970_date_encoding/script: run debugfs less often,
> use $MKE2FS instead of mkfs.ext4, fit within 80 columns
>
> Signed-off-by: Andreas Dilger <adilger@dilger.ca>
This patch is reporting test failures for the new
f_pre_1970_date_encoding. Can you please take a look?
Thanks,
- Ted
--- /usr/projects/e2fsprogs/e2fsprogs/tests/f_pre_1970_date_encoding/expect 2016-03-07 03:17:46.268647450 +0000
+++ f_pre_1970_date_encoding.timestamps.log 2016-03-07 03:20:52.067405831 +0000
@@ -1,45 +1,45 @@
times for year-1909 =
- ctime: 0x8e475440:00000003
- atime: 0x8e475440:00000003
- mtime: 0x8e475440:00000003
-crtime: 0x8e475440:00000003
+ ctime: 0x71b8abc0:00000003
+ atime: 0x71b8abc0:00000003
+ mtime: 0x71b8abc0:00000003
+crtime: 0x71b8abc0:00000003
times for year-1979 =
- ctime: 0x11db6940:00000000
- atime: 0x11db6940:00000000
- mtime: 0x11db6940:00000000
-crtime: 0x11db6940:00000000
+ ctime: 0x05efa740:00000000
+ atime: 0x05efa740:00000000
+ mtime: 0x05efa740:00000000
+crtime: 0x05efa740:00000000
times for year-2039 =
- ctime: 0x82a37b40:00000001
- atime: 0x82a37b40:00000001
- mtime: 0x82a37b40:00000001
-crtime: 0x82a37b40:00000001
+ ctime: 0x0b6de740:00000001
+ atime: 0x0b6de740:00000001
+ mtime: 0x0b6de740:00000001
+crtime: 0x0b6de740:00000001
times for year-2139 =
- ctime: 0x3e9b9940:00000001
- atime: 0x3e9b9940:00000001
- mtime: 0x3e9b9940:00000001
-crtime: 0x3e9b9940:00000001
+ ctime: 0x1495a740:00000001
+ atime: 0x1495a740:00000001
+ mtime: 0x1495a740:00000001
+crtime: 0x1495a740:00000001
times for year-1909 =
- ctime: 0x8e475440:00000000
- atime: 0x8e475440:00000000
- mtime: 0x8e475440:00000000
-crtime: 0x8e475440:00000000
+ ctime: 0x71b8abc0:00000003
+ atime: 0x71b8abc0:00000003
+ mtime: 0x71b8abc0:00000003
+crtime: 0x71b8abc0:00000003
times for year-1979 =
- ctime: 0x11db6940:00000000
- atime: 0x11db6940:00000000
- mtime: 0x11db6940:00000000
-crtime: 0x11db6940:00000000
+ ctime: 0x05efa740:00000000
+ atime: 0x05efa740:00000000
+ mtime: 0x05efa740:00000000
+crtime: 0x05efa740:00000000
times for year-2039 =
- ctime: 0x82a37b40:00000001
- atime: 0x82a37b40:00000001
- mtime: 0x82a37b40:00000001
-crtime: 0x82a37b40:00000001
+ ctime: 0x0b6de740:00000001
+ atime: 0x0b6de740:00000001
+ mtime: 0x0b6de740:00000001
+crtime: 0x0b6de740:00000001
times for year-2139 =
- ctime: 0x3e9b9940:00000001
- atime: 0x3e9b9940:00000001
- mtime: 0x3e9b9940:00000001
-crtime: 0x3e9b9940:00000001
+ ctime: 0x1495a740:00000001
+ atime: 0x1495a740:00000001
+ mtime: 0x1495a740:00000001
+crtime: 0x1495a740:00000001
times for year-1909 =
- ctime: 0x8e475440:00000003
- atime: 0x8e475440:00000003
- mtime: 0x8e475440:00000003
-crtime: 0x8e475440:00000003
+ ctime: 0x71b8abc0:00000003
+ atime: 0x71b8abc0:00000003
+ mtime: 0x71b8abc0:00000003
+crtime: 0x71b8abc0:00000003
next prev parent reply other threads:[~2016-03-07 3:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-18 19:57 [PATCH] e2fsck: Correct ext4 dates generated by old kernels Andreas Dilger
2016-03-07 3:43 ` Theodore Ts'o [this message]
2016-03-07 11:34 ` Andreas Dilger
2016-03-07 15:27 ` Theodore Ts'o
2016-03-09 8:57 ` David Turner
-- strict thread matches above, loose matches on Subject: below --
2015-11-24 21:34 Andreas Dilger
2015-11-24 21:37 ` Andreas Dilger
2015-11-25 6:01 ` David Turner
2015-11-25 9:46 ` Theodore Ts'o
2015-11-26 5:27 ` David Turner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160307034331.GI30238@thunk.org \
--to=tytso@mit.edu \
--cc=adilger@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=novalis@novalis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.