Re: [PATCH 1/2] pwm: add DT bindings for the STMPE PWM

[Thierry Reding <thierry.reding@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1445 bytes --]

On Sun, Feb 14, 2016 at 02:08:37PM +0100, Linus Walleij wrote:
> This adds fairly standard device tree bindings for the STMPE
> PWM found in STMPE24xx multi-purpose expanders.
> 
> Cc: devicetree@vger.kernel.org
> Acked-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
>  Documentation/devicetree/bindings/pwm/st,stmpe-pwm.txt | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/pwm/st,stmpe-pwm.txt
> 
> diff --git a/Documentation/devicetree/bindings/pwm/st,stmpe-pwm.txt b/Documentation/devicetree/bindings/pwm/st,stmpe-pwm.txt
> new file mode 100644
> index 000000000000..c8b53f39ae31
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pwm/st,stmpe-pwm.txt
> @@ -0,0 +1,18 @@
> +== ST STMPE PWM controller ==
> +
> +This is a PWM block embedded in the ST Microelectronics STMPE
> +(ST Multi-Purpose Expander) chips. The PWM is registered as a
> +subdevices of the STMPE MFD device.
> +
> +Required properties:
> +- compatible: should be:
> +  - "st,stmpe-pwm"
> +- #pwm-cells: should be 2. See pwm.txt in this directory for a description of
> +  the cells format.
> +
> +Example:
> +
> +stmpe1_pwm0: stmpe_pwm {

Shouldn't the node name simply be "pwm"? stmpe_pwm is kind of redundant
given that this is to be embedded in an MFD node that will, presumably,
be called stmpe.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]