From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: sergey.senozhatsky.work@gmail.com, akpm@linux-foundation.org,
jack@suse.com, pmladek@suse.com, tj@kernel.org,
linux-kernel@vger.kernel.org, sergey.senozhatsky@gmail.com
Subject: Re: [RFC][PATCH v2 1/2] printk: Make printk() completely async
Date: Mon, 7 Mar 2016 23:36:00 +0900 [thread overview]
Message-ID: <20160307143600.GA835@swordfish> (raw)
In-Reply-To: <201603072010.GDC69723.VFHMFOOSFtLJQO@I-love.SAKURA.ne.jp>
On (03/07/16 20:10), Tetsuo Handa wrote:
[..]
> > > > hm. yes, seems that it may take some time until workqueue wakeup() a ->rescuer thread.
> > > > need to look more.
> > >
> > > Yes, it takes some time (0.1s or 2 jiffies) before workqueue code gives up
> > > creating a worker process and wakes up rescuer thread. However I don't see
> > > that as a problem...
> >
> > yes, that's why I asked Tetsuo whether his concern was a wq's MAYDAY timer
> > delay. the two commits that Tetsuo pointed at earlier in he loop (373ccbe59270
> > and 564e81a57f97) solved the problem by switching to WQ_MEM_RECLAIM wq.
> > I've slightly tested OOM-kill on my desktop system and haven't spotted any
> > printk delays (well, a test on desktop is not really representative, of
> > course).
>
> I wanted to tell that if kworker is running a buggy function that calls
> cond_resched() but does not call schedule_timeout_*() for very long time,
> such delay can become many seconds. WQ_MEM_RECLAIM is a requirement for
> waking up when kworker called schedule_timeout_*(). WQ_MEM_RECLAIM wq can
> still cause huge delay if kworker does not call schedule_timeout_*().
> Not specific to OOM-killer or vmstat.
your point is taken. thanks.
-ss
next prev parent reply other threads:[~2016-03-07 14:38 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-05 10:55 [RFC][PATCH v2 0/2] printk: Make printk() completely async Sergey Senozhatsky
2016-03-05 10:55 ` [RFC][PATCH v2 1/2] " Sergey Senozhatsky
2016-03-06 6:32 ` Sergey Senozhatsky
2016-03-06 7:18 ` Tetsuo Handa
2016-03-06 9:35 ` Sergey Senozhatsky
2016-03-06 11:06 ` Tetsuo Handa
2016-03-06 13:27 ` Sergey Senozhatsky
2016-03-06 14:54 ` Tetsuo Handa
2016-03-07 8:22 ` Jan Kara
2016-03-07 10:12 ` Sergey Senozhatsky
2016-03-07 10:52 ` Jan Kara
2016-03-07 12:16 ` Jan Kara
2016-03-07 12:37 ` Tetsuo Handa
2016-03-07 15:10 ` Sergey Senozhatsky
2016-03-07 15:49 ` Tejun Heo
2016-03-08 10:21 ` Sergey Senozhatsky
2016-03-11 17:22 ` Tejun Heo
2016-03-12 5:01 ` Sergey Senozhatsky
2016-03-09 6:09 ` Sergey Senozhatsky
2016-03-10 9:27 ` Jan Kara
2016-03-10 15:48 ` Sergey Senozhatsky
2016-03-10 9:53 ` Petr Mladek
2016-03-10 16:26 ` Sergey Senozhatsky
2016-03-07 14:40 ` Sergey Senozhatsky
2016-03-07 11:10 ` Tetsuo Handa
2016-03-07 14:36 ` Sergey Senozhatsky [this message]
2016-03-07 15:42 ` Tejun Heo
2016-03-05 10:55 ` [RFC][PATCH v2 2/2] printk: Skip messages on oops Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160307143600.GA835@swordfish \
--to=sergey.senozhatsky@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=jack@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=pmladek@suse.com \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.