All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shaohua Li <shli@kernel.org>
To: Eric Engestrom <eric.engestrom@imgtec.com>
Cc: linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] md/bitmap: remove redundant check
Date: Mon, 7 Mar 2016 09:26:19 -0800	[thread overview]
Message-ID: <20160307172619.GA48300@kernel.org> (raw)
In-Reply-To: <1457352065-28994-1-git-send-email-eric.engestrom@imgtec.com>

On Mon, Mar 07, 2016 at 12:01:05PM +0000, Eric Engestrom wrote:
> daemon_sleep is an unsigned, so testing if it's 0 or less than 1 does
> the same thing.
> 
> Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
> ---
>  drivers/md/bitmap.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/md/bitmap.c b/drivers/md/bitmap.c
> index d80cce4..bbe7b64 100644
> --- a/drivers/md/bitmap.c
> +++ b/drivers/md/bitmap.c
> @@ -510,8 +510,7 @@ static int bitmap_new_disk_sb(struct bitmap *bitmap)
>  	sb->chunksize = cpu_to_le32(chunksize);
>  
>  	daemon_sleep = bitmap->mddev->bitmap_info.daemon_sleep;
> -	if (!daemon_sleep ||
> -	    (daemon_sleep < 1) || (daemon_sleep > MAX_SCHEDULE_TIMEOUT)) {
> +	if (!daemon_sleep || (daemon_sleep > MAX_SCHEDULE_TIMEOUT)) {
>  		printk(KERN_INFO "Choosing daemon_sleep default (5 sec)\n");
>  		daemon_sleep = 5 * HZ;
>  	}

Applied, thanks!

      reply	other threads:[~2016-03-07 17:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-07 12:01 [PATCH] md/bitmap: remove redundant check Eric Engestrom
2016-03-07 12:01 ` Eric Engestrom
2016-03-07 17:26 ` Shaohua Li [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160307172619.GA48300@kernel.org \
    --to=shli@kernel.org \
    --cc=eric.engestrom@imgtec.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.