From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:32999)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1ad7Xn-00056I-NL
	for qemu-devel@nongnu.org; Mon, 07 Mar 2016 21:38:44 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1ad7Xm-00066O-Rv
	for qemu-devel@nongnu.org; Mon, 07 Mar 2016 21:38:43 -0500
Date: Tue, 8 Mar 2016 10:38:32 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20160308023832.GF7119@ad.usersys.redhat.com>
References: <1456564857-29160-1-git-send-email-famz@redhat.com>
	<1456564857-29160-5-git-send-email-famz@redhat.com>
	<56DDCD1C.8000604@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <56DDCD1C.8000604@redhat.com>
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v3 04/15] block: Move block
 dirty bitmap code to separate files
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Max Reitz <mreitz@redhat.com>
Cc: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>, qemu-devel@nongnu.org, qemu-block@nongnu.org

On Mon, 03/07 19:49, Max Reitz wrote:
> On 27.02.2016 10:20, Fam Zheng wrote:
> > The only code change is making bdrv_dirty_bitmap_truncate public. It is
> > used in block.c.
> > 
> > Also two long lines (bdrv_get_dirty) are wrapped.
> > 
> > Signed-off-by: Fam Zheng <famz@redhat.com>
> > Reviewed-by: John Snow <jsnow@redhat.com>
> > ---
> >  block.c                      | 360 ----------------------------------------
> >  block/Makefile.objs          |   2 +-
> >  block/dirty-bitmap.c         | 387 +++++++++++++++++++++++++++++++++++++++++++
> >  include/block/block.h        |  35 +---
> >  include/block/dirty-bitmap.h |  45 +++++
> >  5 files changed, 434 insertions(+), 395 deletions(-)
> >  create mode 100644 block/dirty-bitmap.c
> >  create mode 100644 include/block/dirty-bitmap.h
> 
> [...]
> 
> > diff --git a/include/block/dirty-bitmap.h b/include/block/dirty-bitmap.h
> > new file mode 100644
> > index 0000000..45c6046
> > --- /dev/null
> > +++ b/include/block/dirty-bitmap.h
> > @@ -0,0 +1,45 @@
> > +#ifndef BLOCK_DIRTY_BITMAP_H
> > +#define BLOCK_DIRTY_BITMAP_H
> > +
> > +#include "qemu-common.h"
> > +#include "qemu/hbitmap.h"
> > +
> > +typedef struct BdrvDirtyBitmap BdrvDirtyBitmap;
> 
> Doesn't patch 3 make this superfluous?
> 
> If so, I can remove it for you.
> 

Removing while rebasing.

Fam