From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932654AbcCHJK1 (ORCPT ); Tue, 8 Mar 2016 04:10:27 -0500 Received: from mail-wm0-f66.google.com ([74.125.82.66]:36526 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932199AbcCHJKV (ORCPT ); Tue, 8 Mar 2016 04:10:21 -0500 Date: Tue, 8 Mar 2016 10:10:12 +0100 From: Ingo Molnar To: Arnaldo Carvalho de Melo Cc: linux-kernel@vger.kernel.org, Borislav Petkov , Davidlohr Bueso , Jiri Olsa , Mel Gorman , Peter Zijlstra , Steven Rostedt , Arnaldo Carvalho de Melo Subject: Re: [PATCH 08/15] perf stat: Document --detailed option Message-ID: <20160308091012.GB12413@gmail.com> References: <1457379891-28516-1-git-send-email-acme@kernel.org> <1457379891-28516-9-git-send-email-acme@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1457379891-28516-9-git-send-email-acme@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Arnaldo Carvalho de Melo wrote: > From: Borislav Petkov > > I'm surprised this remained undocumented since at least 2011. And it is > actually a very useful switch, as Steve and I came to realize recently. > > Add the text from > > 2cba3ffb9a9d ("perf stat: Add -d -d and -d -d -d options to show more CPU events") > > which added the incrementing aspect to -d. Ah yes, my fault ... > Signed-off-by: Borislav Petkov > Tested-by: Arnaldo Carvalho de Melo > Cc: Davidlohr Bueso > Cc: Jiri Olsa > Cc: Mel Gorman > Cc: Peter Zijlstra > Cc: Steven Rostedt > Fixes: 2cba3ffb9a9d ("perf stat: Add -d -d and -d -d -d options to show more CPU events") > Link: http://lkml.kernel.org/r/1457347294-32546-1-git-send-email-bp@alien8.de > Signed-off-by: Arnaldo Carvalho de Melo > --- > tools/perf/Documentation/perf-stat.txt | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/tools/perf/Documentation/perf-stat.txt b/tools/perf/Documentation/perf-stat.txt > index 52ef7a9d50aa..14d9e8ffaff7 100644 > --- a/tools/perf/Documentation/perf-stat.txt > +++ b/tools/perf/Documentation/perf-stat.txt > @@ -69,6 +69,14 @@ report:: > --scale:: > scale/normalize counter values > > +-d:: > +--detailed:: > + print more detailed statistics, can be specified up to 3 times > + > + -d: detailed events, L1 and LLC data cache > + -d -d: more detailed events, dTLB and iTLB events > + -d -d -d: very detailed events, adding prefetch events Btw., something I noticed: it would be really nice if 'perf stat -h -d' printed the most detailed documentation available for the option. Right now it prints: triton:~/tip/tools/perf> perf stat -h -d Usage: perf stat [] [] -d, --detailed detailed run - start a lot of events The only way to get to the most detailed documentation is the not very obvious path of: perf help stat and then searching for '-d'. Ideally there should only be a single place to document options - but I guess unifying the in-code option descriptions and more verbose description in the man pages is very non-trivial ... Thanks, Ingo