From: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH 2/5] i40e/i40evf: Add support for bulk free in Tx cleanup
Date: Tue, 8 Mar 2016 11:39:19 -0800 [thread overview]
Message-ID: <20160308113919.000012c8@unknown> (raw)
In-Reply-To: <20160307173003.5682.90872.stgit@localhost.localdomain>
Thanks Alex, one comment below.
On Mon, 7 Mar 2016 09:30:03 -0800
Alexander Duyck <aduyck@mirantis.com> wrote:
> @@ -1975,7 +1977,7 @@ int i40e_napi_poll(struct napi_struct *napi, int budget)
> * budget and be more aggressive about cleaning up the Tx descriptors.
> */
> i40e_for_each_ring(ring, q_vector->tx) {
> - if (!i40e_clean_tx_irq(ring, vsi->work_limit)) {
> + if (!i40e_clean_tx_irq(vsi, ring, budget)) {
> clean_complete = false;
> continue;
> }
I'm not sure if this was a search/replace miss or if you intended it,
but I believe that limiting our transmit cleanup work in i40e_napi_poll
to budget is wrong, as transmit cleanup is so cheap compared to rx,
that we typically don't need to limit it to 64 skbs cleaned. We can't
just have it clean unlimited numbers, so we put in a work limit that is
adjustable via ethtool and defaults to half the ring size.
So this change
1) breaks the ethtool adjustment of tx work_limit, and
2) significantly decreases the number of transmits we will clean per
poll loop.
next prev parent reply other threads:[~2016-03-08 19:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-07 17:29 [Intel-wired-lan] [PATCH 0/5] Bulk Tx cleanup support for Intel wired Ethernet drivers Alexander Duyck
2016-03-07 17:29 ` [Intel-wired-lan] [PATCH 1/5] i40e/i40evf: Fix handling of boolean logic in polling routines Alexander Duyck
2016-03-10 18:37 ` Bowers, AndrewX
2016-03-07 17:30 ` [Intel-wired-lan] [PATCH 2/5] i40e/i40evf: Add support for bulk free in Tx cleanup Alexander Duyck
2016-03-08 19:39 ` Jesse Brandeburg [this message]
2016-03-08 19:58 ` Alexander Duyck
2016-03-10 18:38 ` Bowers, AndrewX
2016-03-07 17:30 ` [Intel-wired-lan] [PATCH 3/5] ixgbe/ixgbevf: Add support for bulk free in Tx cleanup & cleanup boolean logic Alexander Duyck
2016-03-10 18:41 ` Bowers, AndrewX
2016-03-07 17:30 ` [Intel-wired-lan] [PATCH 4/5] fm10k: Add support for bulk " Alexander Duyck
2016-04-14 22:50 ` Singh, Krishneil K
2016-03-07 17:30 ` [Intel-wired-lan] [PATCH 5/5] igb: " Alexander Duyck
2016-03-12 0:44 ` Brown, Aaron F
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160308113919.000012c8@unknown \
--to=jesse.brandeburg@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.