From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean Delvare Subject: Re: [PATCH 6/8] dmi: Move memdev_dmi_entry definition to dmi.h Date: Tue, 8 Mar 2016 13:37:13 +0100 Message-ID: <20160308133713.24e0b71a@endymion> References: <1457399146-4578-1-git-send-email-matthew.d.roper@intel.com> <1457399146-4578-7-git-send-email-matthew.d.roper@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8719089F47 for ; Tue, 8 Mar 2016 12:37:17 +0000 (UTC) In-Reply-To: <1457399146-4578-7-git-send-email-matthew.d.roper@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Matt Roper Cc: Jean Delvare , Mauro Carvalho Chehab , shobhit.kumar@intel.com, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org List-Id: intel-gfx@lists.freedesktop.org SGkgTWF0dCwKCk9uIE1vbiwgIDcgTWFyIDIwMTYgMTc6MDU6NDQgLTA4MDAsIE1hdHQgUm9wZXIg d3JvdGU6Cj4gQSBjb3VwbGUgb2YgdGhlIEVEQUMgZHJpdmVycyBoYXZlIGEgbmljZSBtZW1kZXZf ZG1pX2VudHJ5IHN0cnVjdHVyZSBmb3IKPiBkZWNvZGluZyBETUkgbWVtb3J5IGRldmljZSBlbnRy aWVzLiAgTW92ZSB0aGUgc3RydWN0dXJlIGRlZmluaXRpb24gdG8KPiBkbWkuaCBzbyB0aGF0IGl0 IGNhbiBiZSBzaGFyZWQgYmV0d2VlbiB0aG9zZSBkcml2ZXJzIGFuZCBhbHNvIG90aGVyCj4gcGFy dHMgb2YgdGhlIGtlcm5lbDsgdGhlIGk5MTUgZ3JhcGhpY3MgZHJpdmVyIGlzIGdvaW5nIHRvIG5l ZWQgdG8gdXNlCj4gdGhpcyBzdHJ1Y3R1cmUgc29vbiBhcyB3ZWxsLgoKTG9va3MgZ29vZCBpbiBw cmluY2lwbGUsIGEgZmV3IHN1Z2dlc3Rpb25zIGlubGluZSBiZWxvdzoKCj4gQ2M6IE1hdXJvIENh cnZhbGhvIENoZWhhYiA8bWNoZWhhYkBvc2cuc2Ftc3VuZy5jb20+Cj4gQ2M6IEplYW4gRGVsdmFy ZSA8amRlbHZhcmVAc3VzZS5jb20+Cj4gQ2M6IGxpbnV4LWVkYWNAdmdlci5rZXJuZWwub3JnCj4g Q2M6IGxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmcKPiBTaWduZWQtb2ZmLWJ5OiBNYXR0IFJv cGVyIDxtYXR0aGV3LmQucm9wZXJAaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2VkYWMvZ2hl c19lZGFjLmMgICB8IDI2IC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gIGRyaXZlcnMvZWRh Yy9pN2NvcmVfZWRhYy5jIHwgMjUgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ICBpbmNsdWRl L2xpbnV4L2RtaS5oICAgICAgICB8IDI1ICsrKysrKysrKysrKysrKysrKysrKysrKysKPiAgMyBm aWxlcyBjaGFuZ2VkLCAyNSBpbnNlcnRpb25zKCspLCA1MSBkZWxldGlvbnMoLSkKPiAoLi4uKQo+ IGRpZmYgLS1naXQgYS9pbmNsdWRlL2xpbnV4L2RtaS5oIGIvaW5jbHVkZS9saW51eC9kbWkuaAo+ IGluZGV4IDVlOWM3NGMuLjFlYjIxMzYgMTAwNjQ0Cj4gLS0tIGEvaW5jbHVkZS9saW51eC9kbWku aAo+ICsrKyBiL2luY2x1ZGUvbGludXgvZG1pLmgKPiBAQCAtNzgsNiArNzgsMzEgQEAgc3RydWN0 IGRtaV9oZWFkZXIgewo+ICAJdTE2IGhhbmRsZTsKPiAgfSBfX3BhY2tlZDsKPiAgCj4gK3N0cnVj dCBtZW1kZXZfZG1pX2VudHJ5IHsKCkFzIGEgbWVtYmVyIG9mIHRoZSBBUEkgb2YgdGhlIGRtaSBz dWJzeXN0ZW0sIHRoaXMgc3ltYm9sIHNob3VsZCBzdGFydAp3aXRoIGRtaV8uIFdoYXQgYWJvdXQg ZG1pX2VudHJ5X21lbWRldj8KCj4gKwl1OCB0eXBlOwo+ICsJdTggbGVuZ3RoOwo+ICsJdTE2IGhh bmRsZTsKPiArCXUxNiBwaHlzX21lbV9hcnJheV9oYW5kbGU7Cj4gKwl1MTYgbWVtX2Vycl9pbmZv X2hhbmRsZTsKPiArCXUxNiB0b3RhbF93aWR0aDsKPiArCXUxNiBkYXRhX3dpZHRoOwo+ICsJdTE2 IHNpemU7Cj4gKwl1OCBmb3JtOwo+ICsJdTggZGV2aWNlX3NldDsKPiArCXU4IGRldmljZV9sb2Nh dG9yOwo+ICsJdTggYmFua19sb2NhdG9yOwo+ICsJdTggbWVtb3J5X3R5cGU7Cj4gKwl1MTYgdHlw ZV9kZXRhaWw7Cj4gKwl1MTYgc3BlZWQ7Cj4gKwl1OCBtYW51ZmFjdHVyZXI7Cj4gKwl1OCBzZXJp YWxfbnVtYmVyOwo+ICsJdTggYXNzZXRfdGFnOwo+ICsJdTggcGFydF9udW1iZXI7Cj4gKwl1OCBh dHRyaWJ1dGVzOwo+ICsJdTMyIGV4dGVuZGVkX3NpemU7Cj4gKwl1MTYgY29uZl9tZW1fY2xrX3Nw ZWVkOwo+ICt9IF9fYXR0cmlidXRlX18oKF9fcGFja2VkX18pKTsKCmRtaV9oZWFkZXIgaXMgZGVj bGFyZWQgd2l0aCBfX3BhY2tlZCBpbnN0ZWFkLiBJIHdvdWxkIGFwcHJlY2lhdGUKY29uc2lzdGVu Y3kgd2l0aGluIHRoaXMgaGVhZGVyIGZpbGUsIHNvIHBsZWFzZSB1c2UgX19wYWNrZWQgdG9vLgoK PiArCj4gIHN0cnVjdCBkbWlfZGV2aWNlIHsKPiAgCXN0cnVjdCBsaXN0X2hlYWQgbGlzdDsKPiAg CWludCB0eXBlOwoKVGhhbmtzLAotLSAKSmVhbiBEZWx2YXJlClNVU0UgTDMgU3VwcG9ydApfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFp bGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753983AbcCHMj2 (ORCPT ); Tue, 8 Mar 2016 07:39:28 -0500 Received: from mx2.suse.de ([195.135.220.15]:37188 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932323AbcCHMhX (ORCPT ); Tue, 8 Mar 2016 07:37:23 -0500 Date: Tue, 8 Mar 2016 13:37:13 +0100 From: Jean Delvare To: Matt Roper Cc: intel-gfx@lists.freedesktop.org, mahesh1.kumar@intel.com, shobhit.kumar@intel.com, Mauro Carvalho Chehab , Jean Delvare , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/8] dmi: Move memdev_dmi_entry definition to dmi.h Message-ID: <20160308133713.24e0b71a@endymion> In-Reply-To: <1457399146-4578-7-git-send-email-matthew.d.roper@intel.com> References: <1457399146-4578-1-git-send-email-matthew.d.roper@intel.com> <1457399146-4578-7-git-send-email-matthew.d.roper@intel.com> Organization: SUSE Linux X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.29; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Matt, On Mon, 7 Mar 2016 17:05:44 -0800, Matt Roper wrote: > A couple of the EDAC drivers have a nice memdev_dmi_entry structure for > decoding DMI memory device entries. Move the structure definition to > dmi.h so that it can be shared between those drivers and also other > parts of the kernel; the i915 graphics driver is going to need to use > this structure soon as well. Looks good in principle, a few suggestions inline below: > Cc: Mauro Carvalho Chehab > Cc: Jean Delvare > Cc: linux-edac@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Matt Roper > --- > drivers/edac/ghes_edac.c | 26 -------------------------- > drivers/edac/i7core_edac.c | 25 ------------------------- > include/linux/dmi.h | 25 +++++++++++++++++++++++++ > 3 files changed, 25 insertions(+), 51 deletions(-) > (...) > diff --git a/include/linux/dmi.h b/include/linux/dmi.h > index 5e9c74c..1eb2136 100644 > --- a/include/linux/dmi.h > +++ b/include/linux/dmi.h > @@ -78,6 +78,31 @@ struct dmi_header { > u16 handle; > } __packed; > > +struct memdev_dmi_entry { As a member of the API of the dmi subsystem, this symbol should start with dmi_. What about dmi_entry_memdev? > + u8 type; > + u8 length; > + u16 handle; > + u16 phys_mem_array_handle; > + u16 mem_err_info_handle; > + u16 total_width; > + u16 data_width; > + u16 size; > + u8 form; > + u8 device_set; > + u8 device_locator; > + u8 bank_locator; > + u8 memory_type; > + u16 type_detail; > + u16 speed; > + u8 manufacturer; > + u8 serial_number; > + u8 asset_tag; > + u8 part_number; > + u8 attributes; > + u32 extended_size; > + u16 conf_mem_clk_speed; > +} __attribute__((__packed__)); dmi_header is declared with __packed instead. I would appreciate consistency within this header file, so please use __packed too. > + > struct dmi_device { > struct list_head list; > int type; Thanks, -- Jean Delvare SUSE L3 Support