All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] rtptools: disable for MIPS Codescape toolchains
Date: Tue, 8 Mar 2016 17:11:49 +0100	[thread overview]
Message-ID: <20160308171149.7dff6ff4@free-electrons.com> (raw)
In-Reply-To: <56DEF7EC.20904@imgtec.com>

Hello,

On Tue, 8 Mar 2016 16:03:56 +0000, Vicente Olivert Riera wrote:

> > Isn't the problem that the Codescape toolchain don't provide RPC
> > support at all ? 
> 
> Yes, that's the problem.

Ah, OK. That's a different problem indeed.

> > I don't really like to add random toolchain exclusions without a more
> > serious explanation than "header file is not in toolchain".
> 
> Ok. Perhaps we should make rtptools package depeding on
> BR2_TOOLCHAIN_HAS_NATIVE_RPC?

Well, I just built rtptools with
http://autobuild.buildroot.org/toolchains/configs/br-arm-basic.config,
which does *not* have RPC support, and it builds fine. So it is not
simply that rtptools unconditionally needs RPC support. Looking at the
code, it does:

#ifndef __UCLIBC__
#define HAVE_YP
#endif

#ifdef HAVE_YP
#include <rpcsvc/ypclnt.h>   /* YP */
#endif


So it seems like it has special handling for uClibc. I think you should
replace this with an AC_CHECK_HEADERS test for rpcsvc/ypclnt.h, and use
the HAVE_<foo> variable that will be defined by this test.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2016-03-08 16:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-08 14:23 [Buildroot] [PATCH] rtptools: disable for MIPS Codescape toolchains Vicente Olivert Riera
2016-03-08 15:32 ` Thomas Petazzoni
2016-03-08 16:03   ` Vicente Olivert Riera
2016-03-08 16:11     ` Thomas Petazzoni [this message]
2016-03-09 14:00       ` Vicente Olivert Riera
2016-03-09 14:05         ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160308171149.7dff6ff4@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.