From: Johannes Weiner <hannes@cmpxchg.org>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: linux-mm@kvack.org
Subject: Re: [PATCH] mm,oom: Reduce needless dereference.
Date: Tue, 8 Mar 2016 13:30:32 -0500 [thread overview]
Message-ID: <20160308183032.GA9571@cmpxchg.org> (raw)
In-Reply-To: <1457434951-12691-1-git-send-email-penguin-kernel@I-love.SAKURA.ne.jp>
On Tue, Mar 08, 2016 at 08:02:31PM +0900, Tetsuo Handa wrote:
> Since we assigned mm = victim->mm before pr_err(),
> we don't need to dereference victim->mm again at pr_err().
> This saves a few instructions.
>
> Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Yes. Once we introduce a local variable for something, we should use
it consistently to refer to that thing. Anything else is confusing.
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-03-08 18:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-08 11:02 [PATCH] mm,oom: Reduce needless dereference Tetsuo Handa
2016-03-08 13:32 ` Vlastimil Babka
2016-03-08 18:30 ` Johannes Weiner [this message]
2016-03-09 14:55 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160308183032.GA9571@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=linux-mm@kvack.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.