diff for duplicates of <20160308222125.GG27132@localhost> diff --git a/a/1.txt b/N1/1.txt index 1ebb768..22bc349 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -110,8 +110,8 @@ Rafael thinks otherwise. > +static bool ioport_valid(struct resource *res) > { > - return (res->flags & IORESOURCE_IO) && -> - res->start == 0xCF8 && res->end == 0xCFF; -> + return !(res->start == 0xCF8 && res->end == 0xCFF) && +> - res->start = 0xCF8 && res->end = 0xCFF; +> + return !(res->start = 0xCF8 && res->end = 0xCFF) && > + !(res->end >= 0x10003); Is the "res->end >= 0x10003" test actually fixing a problem? @@ -165,9 +165,9 @@ similar. If it did, it would be fine for res->end to be above > - if (res->end >= 0x10003) > - res->flags |= IORESOURCE_DISABLED | IORESOURCE_UNSET; > - -> if (io_decode == ACPI_DECODE_16) +> if (io_decode = ACPI_DECODE_16) > res->flags |= IORESOURCE_IO_16BIT_ADDR; -> if (translation_type == ACPI_SPARSE_TRANSLATION) +> if (translation_type = ACPI_SPARSE_TRANSLATION) > -- > 2.5.1 > diff --git a/a/content_digest b/N1/content_digest index 2c7ee7c..0dd2bb1 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,7 @@ "ref\01455212827-9382-1-git-send-email-lorenzo.pieralisi@arm.com\0" "From\0Bjorn Helgaas <helgaas@kernel.org>\0" "Subject\0Re: [PATCH v2] PCI: ACPI: IA64: fix IO port generic range check\0" - "Date\0Tue, 8 Mar 2016 16:21:25 -0600\0" + "Date\0Tue, 08 Mar 2016 22:21:25 +0000\0" "To\0Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>\0" "Cc\0linux-pci@vger.kernel.org" linux-acpi@vger.kernel.org @@ -127,8 +127,8 @@ "> +static bool ioport_valid(struct resource *res)\n" "> {\n" "> -\treturn (res->flags & IORESOURCE_IO) &&\n" - "> -\t\tres->start == 0xCF8 && res->end == 0xCFF;\n" - "> +\treturn !(res->start == 0xCF8 && res->end == 0xCFF) &&\n" + "> -\t\tres->start = 0xCF8 && res->end = 0xCFF;\n" + "> +\treturn !(res->start = 0xCF8 && res->end = 0xCFF) &&\n" "> +\t !(res->end >= 0x10003);\n" "\n" "Is the \"res->end >= 0x10003\" test actually fixing a problem?\n" @@ -182,9 +182,9 @@ "> -\tif (res->end >= 0x10003)\n" "> -\t\tres->flags |= IORESOURCE_DISABLED | IORESOURCE_UNSET;\n" "> -\n" - "> \tif (io_decode == ACPI_DECODE_16)\n" + "> \tif (io_decode = ACPI_DECODE_16)\n" "> \t\tres->flags |= IORESOURCE_IO_16BIT_ADDR;\n" - "> \tif (translation_type == ACPI_SPARSE_TRANSLATION)\n" + "> \tif (translation_type = ACPI_SPARSE_TRANSLATION)\n" "> -- \n" "> 2.5.1\n" "> \n" @@ -193,4 +193,4 @@ "> the body of a message to majordomo@vger.kernel.org\n" > More majordomo info at http://vger.kernel.org/majordomo-info.html -464faa896cb0cb5368a8780f8b6b074848a9560f36714653bfab6da9c30154cf +cf6709b33300f74b297bdbee27a44684fafc8f6e1597b721d366da2d05986187
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.