From: Theodore Ts'o <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH 2/6] ext4: Use i_mutex to serialize unaligned AIO DIO
Date: Tue, 8 Mar 2016 22:53:46 -0500 [thread overview]
Message-ID: <20160309035346.GB3150@thunk.org> (raw)
In-Reply-To: <1455897582-13292-3-git-send-email-jack@suse.cz>
On Fri, Feb 19, 2016 at 04:59:38PM +0100, Jan Kara wrote:
> Currently we've used hashed aio_mutex to serialize unaligned AIO DIO.
> However the code cleanups that happened after 2011 when the lock was
> introduced made aio_mutex acquired at almost the same places where we
> already have exclusion using i_mutex. So just use i_mutex for the
> exclusion of unaligned AIO DIO.
>
> The change moves waiting for pending unwritten extent conversion under
> i_mutex. That makes special handling of O_APPEND writes unnecessary and
> also avoids possible livelocking of unaligned AIO DIO with aligned one
> (nothing was preventing contiguous stream of aligned AIO DIOs to let
> unaligned AIO DIO wait forever).
>
> Signed-off-by: Jan Kara <jack@suse.cz>
Thanks, applied.
- Ted
next prev parent reply other threads:[~2016-03-09 3:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-19 15:59 [PATCH 0/6] ext4: Clean up io_end handling for AIO DIO Jan Kara
2016-02-19 15:59 ` [PATCH 1/6] ext4: Pack ioend structure better Jan Kara
2016-03-09 3:39 ` Theodore Ts'o
2016-02-19 15:59 ` [PATCH 2/6] ext4: Use i_mutex to serialize unaligned AIO DIO Jan Kara
2016-03-09 3:53 ` Theodore Ts'o [this message]
2016-02-19 15:59 ` [PATCH 3/6] ext4: Rename and split get blocks functions Jan Kara
2016-03-09 4:09 ` Theodore Ts'o
2016-02-19 15:59 ` [PATCH 4/6] ext4: Move trans handling and completion deferal out of _ext4_get_block Jan Kara
2016-03-09 4:27 ` Theodore Ts'o
2016-02-19 15:59 ` [PATCH 5/6] ext4: Simplify io_end handling for AIO DIO Jan Kara
2016-03-09 4:38 ` Theodore Ts'o
2016-02-19 15:59 ` [PATCH 6/6] ext4: Remove i_ioend_count Jan Kara
2016-03-09 4:53 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160309035346.GB3150@thunk.org \
--to=tytso@mit.edu \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.